-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading through and updating README.md (attempt 2) #20
Reading through and updating README.md (attempt 2) #20
Conversation
Sadly discontinued, but there is a discussion on reviving it on the forum * https://forum.sailfishos.org/t/saving-ownkeepass/6416?u=mikaela
TODO: doctoc
I am pretty sure they don't exist considering what happened with freenode and https://disroot.org/en/blog/matrix-closure (2018)
KiwiIRC gives me error on them being banned on OFTC
I got rate-limited in my poor method of trying to check for expired links and cannot check more now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a SFOS user anymore but the changes looks okay to me
rev: v2.2.0 | ||
hooks: | ||
- id: doctoc | ||
args: [--update-only] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes doctoc
not force itself on everything, while it can be enabled by adding the following anywhere in a file:
<!-- START doctoc -->
<!-- END doctoc -->
However it looks like all files were doctoced before I enabled it, and I don't know whether non-doctoced are desirable.
@@ -32,3 +33,12 @@ edit your PR before we merge it. There's no need to open a new PR, just edit | |||
the existing one. If you're not sure how to do that, | |||
[here is a guide](https://github.com/RichardLitt/knowledge/blob/master/github/amending-a-commit-guide.md) | |||
on the different ways you can update your PR so that we can merge it. | |||
|
|||
## pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling I cannot English here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be overthinking this
* text=auto | ||
README.md merge=union | ||
* text=auto eol=lf merge=union |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't any complicated programming language code here, so I think merge=union
should be a safe strategy for all files.
eol=lf
workarounds thlorenz/doctoc#161 in case anyone uses Windows.
root = true | ||
|
||
[*] | ||
end_of_line = lf | ||
charset = utf-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://editorconfig.org/ configures settings that will apply to multiple text editors just for this repository.
root=true
means that.editorconfig
capable text-editors (see link earlier) won't go looking for configuration from top leve l directories.- line endings are enforced to be
lf
, which the editors should detect automatically though, as a pair to.gitattributes
eol=lf
and to workaround Unusable as 'pre-commit' hook, since it will always fail. thlorenz/doctoc#161 just in case anyone uses Windows. - well I certainly hope everyone uses utf-8
It has been a week from previous comments, is this OK to merge? |
This is revival/rebase of #18 where I missed replies earlier (or have no memory of them).
Resolves: #17
Resolves: #19
TODO