Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtnl: Add ARPHRD_PUREIP netdev type. #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmigunov
Copy link

@bmigunov bmigunov commented Mar 1, 2022

Since ARPHRD_PUREIP netdev type has been introduced in kernel on some of
the MTK-based devices, there have been issues caused by the subject.

This netdev type needs to be handled by ipconfig module, so this commit
adds the support of the ARPHRD_PUREIP by handling appropriate ntelink
events.

@@ -51,6 +51,10 @@
#define ARPHRD_RAWIP_1 (519) /* Vanilla kernel */
#define ARPHRD_RAWIP_2 (530) /* Some android kernels */

/* ARPHRD_PUREIP has been introduced in some MTK kernels (in intention to
* get rid of link local address creation for the ccmni net devices) */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untrue, well, maybe for MTK but in general reason was this https://lkml.org/lkml/2021/6/24/76 and the solution is not really accepted into kernels as of https://lkml.kernel.org/netdev/YNmWwSsZ02iigiHC@kroah.com/

Not yet sure if this is to be included. Upstream might criticize this for sure.

And, multi line comments are formatted (coding-style.txt M2):

/*
 * Line1.
 * Line2.
 */

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment section fixed.
It is possible for me to roll current MTK kernel's ccmni interface netdev type back to ARPHRD_PPP as long as it will not lead to any kind of issues (presumably).
But still, I'll leave this PR as a suggestion because there are no guarantees that ARPHRD_PUREIP will not be used in the future MTK projects.

Since ARPHRD_PUREIP netdev type has been introduced in kernel on some of
the MTK-based devices, there have been issues caused by the subject.

This netdev type needs to be handled by ipconfig module, so this commit
adds the support of the ARPHRD_PUREIP by handling appropriate ntelink
events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants