Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/rewrite contribution example, clean changelog instructions #396

Merged
merged 6 commits into from
Apr 15, 2024

Conversation

LaakkonenJussi
Copy link
Contributor

Rewrite the contribution example to be written in neutral style.

Rewrite the contribution example to be written in neutral style.
Copy link
Contributor

@jovirkku jovirkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for

  • removing the childish Alice style
  • improving the clarity and language greatly.
    I have made a few comments and suggestions. They are not major. From my perspective, this is approved.

Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
Develop/Collaborate/Contribution_Example/README.md Outdated Show resolved Hide resolved
@LaakkonenJussi LaakkonenJussi changed the title Contribution: update/rewrite contribution example Update/rewrite contribution example, clean changelog instructions Mar 27, 2024
Drop the tags as they are for internal use only. Emphasize the
maintainer role in formatting the contribution at merge stage.
Copy link
Contributor

@jovirkku jovirkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new changes look good to me.

These are not relevant with current sfdk. The instructions on how to
add and use additional repositories should be put elsewhere under
advanced help as this is not something a regular contributor should be
required to do.
@Thaodan
Copy link
Contributor

Thaodan commented Apr 11, 2024

Reads good so far to me. I just wonder that removing docs about commit suffixes entirely isn't as good.
I think we should still explain what they do/mean but state the community members don't use them.

Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much much better. Good that contribution references are now gone.

@LaakkonenJussi
Copy link
Contributor Author

Reads good so far to me. I just wonder that removing docs about commit suffixes entirely isn't as good. I think we should still explain what they do/mean but state the community members don't use them.

Many git repositories now have some kind of reference to an issue the change is either resolving or connected to. Our bug references are not relevant for contributing a change so it is good to drop it from here to avoid more confusion. Many, who have the expertise to contribute, will already have the understanding of the basic concepts of bug/issue reference anyways, but it would not hurt to find a some common place to document that. I think contribution example is not the place.

@LaakkonenJussi LaakkonenJussi merged commit 8a30353 into sailfishos:master Apr 15, 2024
4 checks passed
@LaakkonenJussi LaakkonenJussi deleted the jb61617_2 branch April 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants