-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/rewrite contribution example, clean changelog instructions #396
Conversation
Rewrite the contribution example to be written in neutral style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for
- removing the childish Alice style
- improving the clarity and language greatly.
I have made a few comments and suggestions. They are not major. From my perspective, this is approved.
Drop the tags as they are for internal use only. Emphasize the maintainer role in formatting the contribution at merge stage.
9d982db
to
80b903c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new changes look good to me.
These are not relevant with current sfdk. The instructions on how to add and use additional repositories should be put elsewhere under advanced help as this is not something a regular contributor should be required to do.
cc8e533
to
6438fe6
Compare
Reads good so far to me. I just wonder that removing docs about commit suffixes entirely isn't as good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much much better. Good that contribution references are now gone.
Many git repositories now have some kind of reference to an issue the change is either resolving or connected to. Our bug references are not relevant for contributing a change so it is good to drop it from here to avoid more confusion. Many, who have the expertise to contribute, will already have the understanding of the basic concepts of bug/issue reference anyways, but it would not hurt to find a some common place to document that. I think contribution example is not the place. |
Rewrite the contribution example to be written in neutral style.