Skip to content

Commit

Permalink
fix: Bytewax materialization engine fails when loading feature_store.…
Browse files Browse the repository at this point in the history
…yaml (feast-dev#3912)

* bytewax materialization loads yaml config correctly

Signed-off-by: marti-jorda-roca <mjorda98@gmail.com>

* added postgres dependency for SQL registries

Signed-off-by: marti-jorda-roca <mjorda98@gmail.com>

---------

Signed-off-by: marti-jorda-roca <mjorda98@gmail.com>
  • Loading branch information
marti-jorda-roca authored Jan 30, 2024
1 parent 2f99a61 commit 987f0fd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ COPY README.md README.md
# git dir to infer the version of feast we're installing.
# https://github.com/pypa/setuptools_scm#usage-from-docker
# I think it also assumes that this dockerfile is being built from the root of the directory.
RUN --mount=source=.git,target=.git,type=bind pip3 install --no-cache-dir '.[aws,gcp,bytewax,snowflake]'
RUN --mount=source=.git,target=.git,type=bind pip3 install --no-cache-dir '.[aws,gcp,bytewax,snowflake,postgres]'

Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
logging.basicConfig(level=logging.INFO)

with open("/var/feast/feature_store.yaml") as f:
feast_config = yaml.safe_load(f)
feast_config = yaml.load(f, Loader=yaml.Loader)

with open("/var/feast/bytewax_materialization_config.yaml") as b:
bytewax_config = yaml.safe_load(b)
bytewax_config = yaml.load(b, Loader=yaml.Loader)

config = RepoConfig(**feast_config)
store = FeatureStore(config=config)
Expand Down

0 comments on commit 987f0fd

Please sign in to comment.