Fixed tests for expected Map key order #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test suite works by comparing static
String
s to dynamically-generated JSON.For this to work, the tests assume that keys entered added to a
Map
will be returned in the same ordered they were added. The problem is that the tests use aHashMap
to store key/value pairs, and HashMap does not guarantee key order.For these tests to pass, you need to use a
Map
instance that guarantees the order of keys. To that end, I've changed instances ofHashMap
usage toLinkedHashMap
.Now, the tests reliably pass.