feeds: include videos in feeds #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimn
reviewed
Feb 1, 2017
sigal/gallery.py
Outdated
| self.src_filename = filename | ||
| self.date = self._get_file_date() or None |
There was a problem hiding this comment.
_get_file_date should always return a date, so the or None seems useless (and the same above).
There was a problem hiding this comment.
Yes, you're right. I'll remove it.
sigal/plugins/feeds.py
Outdated
| images.sort(key=lambda im: im.date, reverse=True) | ||
| videos = [vid for album in gallery.albums.values() | ||
| for vid in album.videos if vid.date is not None] | ||
| medias = images + videos |
There was a problem hiding this comment.
You can use directly album.medias. (album.images and album.videos are the filtered versions of the first one).
|
Thanks for working on this plugin @jasuarez ! I never really finished it so it is much appreciated. |
Include videos when generating the feeds, besides the images. Also, both for videos and for images without EXIF, use file modification time.
We need to escape them to avoid end up in titles like "today & tomorrow" instead of "today & tomorrow".
|
Thanks @jasuarez ! |
kontza
pushed a commit
to kontza/sigal
that referenced
this pull request
Aug 28, 2020
feeds: include videos in feeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include videos when generating the feeds, besides the images.
Also, both for videos and for images without EXIF, use file modification
time.