Add config option for tweaking how thumbnails should be cropped #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3onyc
force-pushed
the
feature-fit-centering
branch
2 times, most recently
from
dfd2cf4 to
d2f58da
Compare
|
Seems good, thanks ! Could you just add yourself to the AUTHORS file ? |
3onyc
force-pushed
the
feature-fit-centering
branch
from
d2f58da to
f32e4f1
Compare
|
Done |
|
Thanks ! |
kontza
pushed a commit
to kontza/sigal
that referenced
this pull request
Aug 28, 2020
Add config option for tweaking how thumbnails should be cropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows specifying the
centeringparameter ofImageOps.fitin the config file, allowing for tweaks to how thumbnails are cropped withthumb_fit = True.This is the most basic way I could think of implementing this, there's probably a more elegant way, and I'll gladly change this based on suggestions.