Populate title & description from IPTC image data #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IPTC spec defines title and description fields so use those to populate these fields on the Image unless they've been set by some other means.
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 87.48% 87.65% +0.17%
==========================================
Files 19 19
Lines 1358 1377 +19
==========================================
+ Hits 1188 1207 +19
Misses 170 170
Continue to review full report at Codecov.
|
saimn
reviewed
Feb 14, 2018
sigal/gallery.py
Outdated
| if iptc_data and not self.description: | ||
| # 2:120 is the IPTC description property | ||
| if (2, 120) in iptc_data: | ||
| self.description = iptc_data[(2, 120)].decode('utf-8') |
There was a problem hiding this comment.
I think you could put the details of how to get title and description in get_iptc_data, it would make the function easier to test and more self-contained, and avoid to do this directly in Image which does not have to know how IPTC work.
|
@edwinsteele - What is the license of the images ? If you are the author of these images, do you agree do share them with sigal's license ? |
|
It’s my image (1.jpg and 2.jpg are the same image) and I’m happy to share it under an MIT licence.
…--
Edwin Steele e: edwin@wordspeak.org w: https://wordspeak.org
On 15 Feb 2018, 20:14 +1100, Simon Conseil ***@***.***>, wrote:
@edwinsteele - What is the license of the images ? If you are the author of these images, do you agree do share them with sigal's license ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Great, merging then, thanks! |
kontza
pushed a commit
to kontza/sigal
that referenced
this pull request
Aug 28, 2020
…from-iptc Populate title & description from IPTC image data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPTC spec defines title and description fields so use those
to populate these fields on the Image unless they've been set by
some other means, thus preserving existing behaviour.
This provides a pattern that could be used with #249