-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust background colors of medium/dark and hard/dark #108
Conversation
@antoineco @jef Could you test the medium/dark and the hard/dark variants on your machine? |
I think that looks alright, slightly more contrast. I'm a Macbook user and I wasn't bothered by the original palette though. Here is an animated comparison of the changes for the medium/dark variant: |
375a039
to
552851c
Compare
In the picture you shared the MacBook seems to actually have a darker background to me, with a deeper contrast, whereas the Surface looks blue-ish. Anyway, I don't have a strong opinion on this because every time I use a different display the colors are slightly different for any given program I use. I think it's easy to get biased by using a device much more often than another. |
Actually I feel that surface book has higher contrast. This color scheme looks foggy in MacBook and I think a darker background might look better. This color scheme is originally designed in surface book so everything looks OK on it, but when using it on MacBook I always feel that something goes wrong, so I think the palette may need to be adjusted. Another reason is that I want the three variants more distinguishable, so I want the medium and hard variants to be darker. |
Works for me, I like the new background palette! |
552851c
to
e1fdfc8
Compare
Wouldn't this require a lot of work to update all of the plugins for various applications? And if everforest is going through a palette change, maybe just making a separate color scheme entirely like everforest 2.0 would be a better idea considering it's technically going to be a different colorscheme. |
Yeah, that's a problem, I'll email the plugin authors, hope they can follow the changes.
I'd like to consider this as an enhancement or a fix, which should happen on current color scheme. I don't think it's necessary to create a separate color scheme. Btw, the changes are small, it's OK to continue to use the original palette. |
While I do agree, I still think the change should only be made when all of the plugin authors have been able to update their plugins. |
Adjust palettes and assignments: Color palettes of upstream everforest where tweaked since creation of this port: - sainnhe/everforest#108 - sainnhe/everforest#109 These adjustments move the helix everforest theme closer to the dcocumented upstream vim theme
Adjust palettes and assignments: Color palettes of upstream everforest where tweaked since creation of this port: - sainnhe/everforest#108 - sainnhe/everforest#109 These adjustments move the helix everforest theme closer to the dcocumented upstream vim theme
Adjust palettes and assignments: Color palettes of upstream everforest where tweaked since creation of this port: - sainnhe/everforest#108 - sainnhe/everforest#109 These adjustments move the helix everforest theme closer to the dcocumented upstream vim theme
Adjust palettes and assignments: Color palettes of upstream everforest where tweaked since creation of this port: - sainnhe/everforest#108 - sainnhe/everforest#109 These adjustments move the helix everforest theme closer to the dcocumented upstream vim theme
Adjust palettes and assignments: Color palettes of upstream everforest where tweaked since creation of this port: - sainnhe/everforest#108 - sainnhe/everforest#109 These adjustments move the helix everforest theme closer to the dcocumented upstream vim theme
Adjust palettes and assignments: Color palettes of upstream everforest where tweaked since creation of this port: - sainnhe/everforest#108 - sainnhe/everforest#109 These adjustments move the helix everforest theme closer to the dcocumented upstream vim theme
Adjust palettes and assignments: Color palettes of upstream everforest where tweaked since creation of this port: - sainnhe/everforest#108 - sainnhe/everforest#109 These adjustments move the helix everforest theme closer to the dcocumented upstream vim theme
Description
After using this color scheme for a period of time, I found some issues in the color palette.
In this PR I'm trying to make the background colors of the medium/dark and hard/dark variants darker, and make them more distinguishable between each other.
I may try to adjust the light variants in a separate PR.