Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto closing popup window #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awerebea
Copy link

@awerebea awerebea commented Nov 4, 2021

Fix popup disappearing on tmux 3.3-rc.

@sainnhe
Copy link
Owner

sainnhe commented Nov 5, 2021

Thanks!

Looks like you can't close popup via Enter anymore, so the only way to close it is using Ctrl-C?

@awerebea
Copy link
Author

awerebea commented Nov 5, 2021

Looks like you can't close popup via Enter anymore, so the only way to close it is using Ctrl-C?

Hello!
No, I had another problem. The popup disappears immediately after it appears. With these changes, I can close the popup manually using Esc and Ctrl-C (but not with Enter).

@sainnhe
Copy link
Owner

sainnhe commented Nov 5, 2021

I can't reproduce this bug on tmux 3.2a stable release, the original code works fine. And with your code, I can't close popup via Esc.

I'm going to test it on development version later.

@awerebea
Copy link
Author

awerebea commented Nov 5, 2021

I tried it on version 3.2a of tmux and I have the same behavior, so I believe it is not a version related issue.
Also I tried to disable all other tmux plugins but with no success.
After that, I thought it might somehow conflict with my zsh plugins, and tried it in bash, but everything remained the same.
It is very strange that you cannot close popup with Esc. If so, you can reject this PR and I will continue to use this plugin from my fork, no problem.
Thanks for your attention anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants