-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix barcode helper #14
Comments
itsmattking
added a commit
that referenced
this issue
Oct 4, 2024
Breaks out `BarCode` into abstract class and creates `BarCode39` and `BarCode128`. Further bar code definitions should use `BarCode` as the base class.
itsmattking
added a commit
that referenced
this issue
Oct 5, 2024
PR feedback: - Make `BarCode` an `interface` - Use `table` entries for tests - Doc consistency fixes
itsmattking
added a commit
that referenced
this issue
Oct 7, 2024
* [#14] Update barcode helper Breaks out `BarCode` into abstract class and creates `BarCode39` and `BarCode128`. Further bar code definitions should use `BarCode` as the base class. * [#14] Update barcode helper PR feedback: - Make `BarCode` an `interface` - Use `table` entries for tests - Doc consistency fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Barcode helper is hard coded to
^B1
(1
being a barcode type). It needs to either be separated out to a specific barcode helper, or accept a barcode type parameter.The text was updated successfully, but these errors were encountered: