Replace cosmiconfig with lilconfig to Work with Webpack #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpack will replace `require` and `import` by default, `lilconfig` is a zero-dependency laternative to `cosmiconfig` with the same API, and the most recent version handles the webpack case.
|
Hi @atkinchris, could you please review this PR and the others? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #29
Description
Webpack will try to bundle modules during compile time and replace the original
require, so usingrequiredirectly in the Webpack context to load configs could result in MODULE_NOT_FOUND error. next-logger uses the sync API ofcosmiconfigto load its config, which internally usesimport-freshto handle the config loading, andimport-freshunderneath uses the plainrequire. This has been causing the issues mentioned in #13 (comment) and #29While trying to fix the issue (PR: sindresorhus/import-fresh#27), it seems that
import-freshis not actively maintained.lilconfigis a zero-dependency alternative tocosmiconfigwith the same API and more lightweight, and just released a new version 3.1.2 with the same fix.I am proposing to use
lilconfiginstead in this PR to fix the config loading issue and hopefully avoid some issues caused by legacy components in the future.Testing
npm run test