Remove duplication when loading templates

Previously we'd fetch the same files over and over again. Instead load them all
on init, since they don't change and they're frequently needed/reused.

assets/doc.go

@@ -6,10 +6,6 @@
 // example.
 package assets
 
-func AssetString(name string) (string, error) {
-	b, err := Asset(name)
-	if err != nil {
-		return "", err
-	}
-	return string(b), nil
+func MustAssetString(name string) string {
+	return string(MustAsset(name))
 }

server/calls.go

@@ -14,7 +14,6 @@ import (
 	types "github.com/kevinburke/go-types"
 	"github.com/kevinburke/rest"
 	twilio "github.com/kevinburke/twilio-go"
-	"github.com/saintpete/logrole/assets"
 	"github.com/saintpete/logrole/config"
 	"github.com/saintpete/logrole/services"
 	"github.com/saintpete/logrole/views"
@@ -37,26 +36,6 @@ type callListServer struct {
 func newCallListServer(l log.Logger, vc views.Client, lf services.LocationFinder,
 	pageSize uint, maxResourceAge time.Duration,
 	secretKey *[32]byte) (*callListServer, error) {
-	base, err := assets.AssetString("templates/base.html")
-	if err != nil {
-		return nil, err
-	}
-	listTpl, err := assets.AssetString("templates/calls/list.html")
-	if err != nil {
-		return nil, err
-	}
-	pagingTpl, err := assets.AssetString("templates/snippets/paging.html")
-	if err != nil {
-		return nil, err
-	}
-	phoneTpl, err := assets.AssetString("templates/snippets/phonenumber.html")
-	if err != nil {
-		return nil, err
-	}
-	copyScript, err := assets.AssetString("templates/snippets/copy-phonenumber.js")
-	if err != nil {
-		return nil, err
-	}
 	cs := &callListServer{
 		Logger:         l,
 		Client:         vc,
@@ -67,7 +46,7 @@ func newCallListServer(l log.Logger, vc views.Client, lf services.LocationFinder
 	}
 	templates, err := template.New("base").Option("missingkey=error").Funcs(funcMap).Funcs(template.FuncMap{
 		"is_our_pn": vc.IsTwilioNumber,
-	}).Parse(base + listTpl + pagingTpl + phoneTpl + copyScript)
+	}).Parse(base + callListTpl + pagingTpl + phoneTpl + copyScript)
 	if err != nil {
 		return nil, err
 	}
@@ -84,38 +63,14 @@ type callInstanceServer struct {
 
 func newCallInstanceServer(l log.Logger, vc views.Client,
 	lf services.LocationFinder) (*callInstanceServer, error) {
-	base, err := assets.AssetString("templates/base.html")
-	if err != nil {
-		return nil, err
-	}
-	instanceTpl, err := assets.AssetString("templates/calls/instance.html")
-	if err != nil {
-		return nil, err
-	}
-	phoneTpl, err := assets.AssetString("templates/snippets/phonenumber.html")
-	if err != nil {
-		return nil, err
-	}
-	copyScript, err := assets.AssetString("templates/snippets/copy-phonenumber.js")
-	if err != nil {
-		return nil, err
-	}
-	recordingTpl, err := assets.AssetString("templates/calls/recordings.html")
-	if err != nil {
-		return nil, err
-	}
-	sidTpl, err := assets.AssetString("templates/snippets/sid.html")
-	if err != nil {
-		return nil, err
-	}
 	c := &callInstanceServer{
 		Logger:         l,
 		Client:         vc,
 		LocationFinder: lf,
 	}
 	templates, err := template.New("base").Option("missingkey=error").Funcs(funcMap).Funcs(template.FuncMap{
 		"is_our_pn": vc.IsTwilioNumber,
-	}).Parse(base + instanceTpl + recordingTpl + phoneTpl + sidTpl + copyScript)
+	}).Parse(base + callInstanceTpl + recordingTpl + phoneTpl + sidTpl + copyScript)
 	if err != nil {
 		return nil, err
 	}

server/conferences.go

@@ -0,0 +1 @@
+package server