Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50468 Grader should scroll with instructor on desktop instead of overlaying #13373

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ottenhoff
Copy link
Contributor

@ottenhoff ottenhoff commented Feb 27, 2025

TASKS:

  • Works on desktop
  • Works on mobile
  • Works on iPad
  • Remove the ability to Show All Feedback comment
  • Refine text
  • Is there a need for the word "Grader"?
  • Should DONE button also do a SAVE? Why not .....
  • Test dark mode vs light mode
  • Hide Cancel button desktop (cant get rid of GRADER)
  • Test on Firefox
  • Test on Safari
Screenshot 2025-02-27 at 1 41 55 PM Screenshot 2025-02-27 at 12 12 00 PM

@adrianfish
Copy link
Contributor

I think the word Grader is ok, tbh. It just makes it clear that that is the grading area and doesn't really take up a load of space.
Remove is quicker than editing the text I think. Less clicks.

Generally, I was kind of expecting this JIRA. I think I went a bit too mobile first on it.

@ottenhoff
Copy link
Contributor Author

Thanks. The mobile first is great. But yeah, power users are asking now .....

Remove is definitely quicker. I guess I wonder how often someone is removing entirely vs editing.

Obviously I'm trying to save screen real estate so that the GRADER panel can be fixed size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants