Composables with Modifier.zoomable() aren't drawn on first frame #8
Assignees
Labels
enhancement
New feature or request
Comments
saket
added
enhancement
|
7d3a13c fixes this partially by making layout previews work for |
github-merge-queue bot
referenced
this issue
in slackhq/circuit
Feb 18, 2024
…1215) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [me.saket.telephoto:zoomable-image-coil](https://togithub.com/saket/telephoto) | dependencies | minor | `0.7.1` -> `0.8.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>saket/telephoto (me.saket.telephoto:zoomable-image-coil)</summary> ### [`v0.8.0`](https://togithub.com/saket/telephoto/releases/tag/0.8.0) [Compare Source](https://togithub.com/saket/telephoto/compare/0.7.1...0.8.0) Breaking changes - Reordered `SubSamplingImage()`'s parameters to move `Modifier` below all required parameters. New changes - Update Compose UI to `1.6.1` and Compose Multiplatform to `1.6.0-rc02` - Introduced [ZoomableState#transformedContentBounds](https://togithub.com/saket/telephoto/blob/706cf08cb976c0d9d9c6d0f95e4e64fc4efbf4ef/zoomable/src/commonMain/kotlin/me/saket/telephoto/zoomable/ZoomableState.kt#L88-L96) for observing transformed content bounds. This can be used for drawing decorations around the content or performing hit tests. - Placeholder images now respond to click listeners. Additionally, they will swallow all other zoom gestures instead of ignoring them. - [https://github.com/saket/telephoto/issues/3](https://togithub.com/saket/telephoto/issues/3): Read color space of bitmaps from Coil and Glide. Bug fixes - [https://github.com/saket/telephoto/issues/60](https://togithub.com/saket/telephoto/issues/60), [https://github.com/saket/telephoto/issues/65](https://togithub.com/saket/telephoto/issues/65): Improved detection of pinch-to-zoom gestures. - [https://github.com/saket/telephoto/issues/8](https://togithub.com/saket/telephoto/issues/8): Composables with `Modifier.zoomable()` are now drawn on the first frame. This fixes their broken layout preview. - [https://github.com/saket/telephoto/issues/58](https://togithub.com/saket/telephoto/issues/58): Fixed a resource leak when an image's EXIF metadata is read. - `ZoomableState#resetZoom()` now calculates the content's position on the same UI frame. - Images no longer flicker on start when they can't zoom-in any further. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTQuMyIsInVwZGF0ZWRJblZlciI6IjM3LjE5NC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This breaks static previews, though interactive ones work.
Maybe check for
ZoomableContentLocation.SameAsLayoutBounds, and if present, fallback toScaleFactor(1, 1)rather thanScaleFactor.Zero?The text was updated successfully, but these errors were encountered: