RU-MAKEAPP: refactor(run)!: cleanup run method (#1266) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(run)!: get rid of emit-and-throw & throw-literal antipatterns * refactor(run)!: convert run method to async/await * refactor(run): require build module in advance * refactor(run): minor cleanup * refactor(run): drop always-undefined option arch `parseBuildOptions` only sets `arch` if something truthy is passed for parameter `resolvedTarget` to which we pass `null`. * refactor(run): destructure buildOptions
sakibguy
added
bug
* refactor(emulator): require emulatorId in emulator.run * refactor: use effective targetSdk to find best emulator
* fix(Api): do not infer project root from script location * fix(builders): do not infer project root from script location * fix(target): do not infer project root from script location * test(e2e): cleanup and extend E2E tests - Renames the file with the only existing E2E test - Makes existing test use the API instance returned by `Api.createPlatform` - Adds another test that ensures we can still require the API from `platformProjectPath/cordova/Api.js` * fix(check_reqs): do not infer project root from script location
Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
sakibguy
commented
Jul 13, 2021
sakibguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(run)!: get rid of emit-and-throw & throw-literal antipatterns
refactor(run)!: convert run method to async/await
refactor(run): require build module in advance
refactor(run): minor cleanup
refactor(run): drop always-undefined option arch
parseBuildOptionsonly setsarchif something truthy is passed forparameter
resolvedTargetto which we passnull.Platforms affected
Motivation and Context
Description
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))