Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Volume up/down for scroll up/down mouse actions #71

Closed
HubKing opened this issue Feb 11, 2023 · 9 comments
Closed

[Feature Request] Volume up/down for scroll up/down mouse actions #71

HubKing opened this issue Feb 11, 2023 · 9 comments
Assignees
@sakithb
Labels
enhancement New feature or request

Comments

@HubKing
Copy link

HubKing commented Feb 11, 2023 •
edited
Loading

If it is technically possible, please add volume up/down to the drop-down list in Mouse actions. It would be convenient if the user can adjust the song's volume by the scroll wheel, without opening the player's UI.

I mean, not the system audio volume, but the song's volume within the player. For example, Strawberry music player has the volume slider on the bottom-left corner.

image

image
@inxendere
Copy link

bump

@ChrisLauinger77 ChrisLauinger77 added the enhancement New feature or request label Oct 6, 2023
@ChrisLauinger77
Copy link
Collaborator

#50 is also about volume control.

@sakithb
Copy link
Owner

sakithb commented Oct 15, 2023

I just tested this and it is possible to implement, I will add this to the backlog.

@sakithb sakithb self-assigned this Oct 15, 2023
@sakithb sakithb moved this to 📋 Backlog in Media Controls v28/v29 Oct 15, 2023
@sakithb sakithb moved this from 📋 Backlog to 🏗 In progress in Media Controls v28/v29 Oct 17, 2023
sakithb added a commit that referenced this issue Oct 17, 2023
@sakithb
#71 source volume control for mouse actions
c37c7b1
@sakithb sakithb moved this from 🏗 In progress to ✅ Done in Media Controls v28/v29 Oct 17, 2023
@sakithb sakithb moved this from ✅ Done to 👀 In review in Media Controls v28/v29 Oct 18, 2023
ChrisLauinger77 pushed a commit that referenced this issue Oct 18, 2023
@sakithb @ChrisLauinger77
#71 source volume control for mouse actions
942adca
@ChrisLauinger77
Copy link
Collaborator

overtook it to main - added translation as well

@ChrisLauinger77
Copy link
Collaborator

ChrisLauinger77 commented Oct 18, 2023 •
edited
Loading

does not work with firefox though - maybe update the known issues section ?
VLC worked for me

@sakithb
Copy link
Owner

sakithb commented Oct 19, 2023

does not work with firefox though - maybe update the known issues section ? VLC worked for me

Firefox probably does not support the mpris methods

@sakithb
Copy link
Owner

sakithb commented Oct 19, 2023

Can confirm it doesn't work on chromium based browsers as well

@ChrisLauinger77
Copy link
Collaborator

So known limitation

@sakithb
Copy link
Owner

sakithb commented Oct 19, 2023

Yes

@sakithb sakithb moved this from 👀 In review to ✅ Done in Media Controls v28/v29 Oct 23, 2023
@sakithb sakithb closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakithb sakithb

Labels
enhancement New feature or request
Projects
No open projects
Media Controls v28/v29
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChrisLauinger77 @HubKing @sakithb @inxendere