Bugfix/313/invalid session #323
Conversation
…/313/invalid-session-id
…/313/invalid-session-id
…/313/invalid-session-id
…/313/invalid-session-id
svettwer
changed the base branch from
bugfix/314/getDriver-driver-from-undefined
to
develop
There was a problem hiding this comment.
When I run the tests, I noticed that the following message appears in the output:
jest-haste-map: duplicate manual mock found: index
The following files share their name; please delete one of them:
* <rootDir>/context/__mocks__/index.ts
* <rootDir>/context/sahi/__mocks__/index.ts
I also want to note, that you added comments like // noinspection HtmlRequiredAltAttribute,HtmlDeprecatedAttribute , which disables the warnings in IntelliJ. This does not affect VS Code users as they don't have a html inspection like in IntelliJ. Do we want those lines in our code?
| const webDriverMock = createWebDriverMock(jest.fn() | ||
| .mockResolvedValueOnce("<html></html>") | ||
| .mockResolvedValueOnce("<html><div></div></html>") | ||
| .mockResolvedValueOnce("<html></html>") | ||
| .mockResolvedValueOnce("<html><div></div></html>") | ||
| .mockResolvedValueOnce("<html></html>")); |
There was a problem hiding this comment.
This webDriverMock is also used in should not wait longer than the timeout defines. I think we can refactor this into a function.
| const webDriverMock = createWebDriverMock(jest.fn() | ||
| .mockResolvedValueOnce("<html></html>") | ||
| .mockResolvedValue("<html><div></div></html>")); |
There was a problem hiding this comment.
This webDriverMock was also used in should wait if page is changing its dom over time. I think we can refactor this into a function.
|
Hiho! 👋 Thx for the review. The duplicate was a good catch! 👍 BR, |
… making mistakes.
Concerning this, I'm not sure where this comes from. I checked the implementation and could not find a duplicated manual mock... 🤔 |
|
Kudos, SonarCloud Quality Gate passed!
|
I think it's jestjs/jest#2070 |
|
Okay, then I'd recommend to ignore it. As the PR in the issue is merged since August 19 it might be fixed when we update jest. |
This PR is based on the changes of #319. I'll rebase the PR in case #319 is merged earlier.