#1185 での rebase の誤りを修正 #1187
Merged
#1185 での rebase の誤りを修正 #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
approved these changes
Feb 9, 2020
いいことにします。 |
私が確認を端折ったのが原因です。 |
|
https://ci.appveyor.com/project/sakuraeditor/sakura/builds/30672806/job/9crfte5e7865dx9c/artifacts の sakura-PR1187-build2612-2c50ae8-Win32-Release-Log.zip で githash.h 確認して OK でした。 sakura-PR1187-build2612-2c50ae8-Win32-Release-Exe.zip でも Github へのリンクに飛べるのを確認しました。 |
|
CI 終わったらマージします。 |
|
✅ Build sakura 1.0.2612 completed (commit 2c50ae8882 by @m-tmatma) |
This was referenced Feb 9, 2020
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 16, 2020
…fixup-PR1185 sakura-editor#1185 での rebase の誤りを修正
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
#1185 での rebase の誤りを修正
カテゴリ
PR の背景
#1183 で PR を分割して #1185 を作成する際に、rebase 操作で変更を分割する際に
appeyor 側の修正ではなく、あやまって azure pipeline の修正を入れてしまった。
その部分のみ修正する。
PR のメリット
#1185 がマージされた状態で GitHub コミット URL の機能が動作しなくなる問題が修正される。
PR のデメリット (トレードオフとかあれば)
なし
PR の影響範囲
appveyor ビルドでの GitHub コミット URL
関連チケット
#1185
#1183
参考資料