Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sakura_lang_en_US.dll のバージョンにGitHash が含まれない #159

Merged
merged 1 commit into from
Jun 23, 2018
Merged

sakura_lang_en_US.dll のバージョンにGitHash が含まれない #159

merged 1 commit into from
Jun 23, 2018

Conversation

m-tmatma
Copy link
Member

#157: GitHash が反映されない問題を修正

gitrev.h がインクルードされていない。

@m-tmatma m-tmatma added the 🐛bug🦋 ■バグ修正(Something isn't working) label Jun 22, 2018
This was referenced Jun 22, 2018
Closed
Merged
@m-tmatma m-tmatma changed the title GitHash が反映されない問題を修正 sakura_lang_en_US.dll のバージョンにGitHash が含まれない Jun 23, 2018
@m-tmatma m-tmatma added this to the next release milestone Jun 23, 2018
berryzplus
berryzplus approved these changes Jun 23, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

sakura_core/sakura_rc.rc に SAKURA_LANG_RESOURCE を見る分岐が入っていることについての違和感は別途ヒマなときに議論したいです。

@kobake
Copy link
Member

kobake commented Jun 23, 2018

同じくLGTM。エビデンス貼っておきます。

verhash

@kobake kobake merged commit 706855d into sakura-editor:master Jun 23, 2018
@m-tmatma m-tmatma deleted the feature/fix-sakura_lang_en_US-GitHash branch June 23, 2018 08:48
@m-tmatma
Copy link
Member Author

sakura_core/sakura_rc.rc に SAKURA_LANG_RESOURCE を見る分岐が入っていることについての違和感は別途ヒマなときに議論したいです。

#159 で登録してます。

@ds14050 ds14050 added the 🐛bug🦋 ■バグ修正(Something isn't working) label Sep 18, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@kobake
Merge pull request sakura-editor#159 from m-tmatma/feature/fix-sakura…
f01e09d 
…_lang_en_US-GitHash

sakura_lang_en_US.dll のバージョンにGitHash が含まれない
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
🐛bug🦋 ■バグ修正(Something isn't working)
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@m-tmatma @kobake @berryzplus @ds14050