Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HighDPI対応 アプリケーションのアイコン表示 #517

Merged
merged 2 commits into from
Oct 4, 2018
Merged

HighDPI対応 アプリケーションのアイコン表示 #517

merged 2 commits into from
Oct 4, 2018

Conversation

beru
Copy link
Contributor

@beru beru commented Oct 4, 2018

変更前 変更後
image image

GetAppIcon 関数は色々なところで使われているようで、色々な箇所が一気に直りました。

m-tmatma
m-tmatma approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@m-tmatma m-tmatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

スクリーンショットの通りになりました。
変更内容も問題なさそうです。

@beru
Copy link
Contributor Author

beru commented Oct 4, 2018

レビューありがとうございます。それでは Merge します。
もし問題が見つかったら別 PR で対処する事にしましょう。

@beru beru merged commit 5ea5aee into sakura-editor:master Oct 4, 2018
@beru beru deleted the HighDPI_GetAppIcon branch October 4, 2018 22:06
@beru beru mentioned this pull request Oct 4, 2018
Open
11 tasks
@m-tmatma m-tmatma added this to the next release milestone Oct 21, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@beru
Merge pull request sakura-editor#517 from beru/HighDPI_GetAppIcon
1c01661 
HighDPI対応 アプリケーションのアイコン表示
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-tmatma m-tmatma m-tmatma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@beru @m-tmatma