Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use special build of electron dev tools (4.27, with Manifest V2) #1

Closed
wants to merge 3 commits into from

Conversation

Marcus10110
Copy link

@Marcus10110 Marcus10110 commented Feb 8, 2024

This PR is for reference only, we should generally not merge to the main branch of a fork.

It replaces the included version of React Dev Tools (4.28.5 at the time of the fork) with a custom older version, as downloaded from here:

facebook/react#25843 (comment)

This is because Electron (tested on version 27) does not support the V3 manifest yet. This custom build of react dev tools uses the V2 manifest, and is known to work with Electron 27.

@Marcus10110 Marcus10110 marked this pull request as draft February 8, 2024 18:49
@Marcus10110 Marcus10110 marked this pull request as ready for review February 8, 2024 19:03
@Marcus10110 Marcus10110 marked this pull request as draft February 8, 2024 19:03
@Marcus10110
Copy link
Author

closing, since it's still available for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant