Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font-awesome icon selection to alarm markdown sugar #78

Merged
merged 3 commits into from
Jan 25, 2019

Conversation

kakposoe
Copy link
Contributor

@kakposoe kakposoe commented Jan 25, 2019

Hi there!

I've been tinkering around with some functionality to add the ability to use font-awesome icons to alarm markdown sugars.

Below is an example of new functionality to be added with this pull request:

> {danger.fa-exclamation-triangle} This is dangerous

img-2019-01-25-150511

> {success.fa-check} This worked

img-2019-01-25-152618

Alert sugars will now check to see the alarm type and if a font awesome icon have been declared using a dot notation (e.g {success.fa-check}).

Note: As this plugin currently uses font awesome 4.7.0, a suggestion would be made to upgrade to use a later version (>=5.0.0) to avoid confusion.

There is also a small refactor of the default svg icons.

@kakposoe
Copy link
Contributor Author

Another change would be need to update to a later version of font awesome as the class definitions has changed (e.g .far .fa-check).

@saleem-hadad
Copy link
Owner

This is awesome ❤️
thank you very much @kakposoe

@saleem-hadad saleem-hadad merged commit a8e3874 into saleem-hadad:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants