Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button font weights #777

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix button font weights #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15f90ea
Fix button font weights
Droniu Mar 18, 2024
18d8644
Add changeset
Droniu Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lemon-tools-tan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@saleor/macaw-ui": patch
---

This change adds bold font weight to button component and lowers bold font weight from 700 to 600.
1 change: 1 addition & 0 deletions src/components/Button/Button.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export const button = recipe({
placeItems: "center",
padding: 0,
textDecoration: "none",
fontWeight: "bold",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I'd be explicit here nad put 600 instead of bold.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is mapped to token from theme (this is sprinkles context).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also bold is actually 700 in the web API, perhaps it should be changed to semibold in sprinkles tokens

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave up to you - you will need to migrate Dashboard as well 🤔

cursor: {
default: "pointer",
disabled: "not-allowed",
Expand Down
2 changes: 1 addition & 1 deletion src/theme/themes/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const fontWeight = {
light: "300",
regular: "400",
medium: "500",
bold: "700",
bold: "600",
};

export const letterSpacing = {
Expand Down
Loading