Fix redirect loop on login with external provider

saleor · Jun 6, 2023 · 455602c · 455602c
1 parent 5e6d128
commit 455602c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/auth/components/LoginPage/LoginPage.tsx b/src/auth/components/LoginPage/LoginPage.tsx
@@ -29,7 +29,7 @@ export interface LoginCardProps {
   onSubmit?: (event: LoginFormData) => SubmitPromise;
 }
 
-const LoginCard: React.FC<LoginCardProps> = props => {
+const LoginPage: React.FC<LoginCardProps> = props => {
   const {
     errors,
     disabled,
@@ -179,5 +179,5 @@ const LoginCard: React.FC<LoginCardProps> = props => {
     </LoginForm>
   );
 };
-LoginCard.displayName = "LoginCard";
-export default LoginCard;
+LoginPage.displayName = "LoginPage";
+export default LoginPage;
diff --git a/src/auth/views/Login.tsx b/src/auth/views/Login.tsx
@@ -63,15 +63,13 @@ const LoginView: React.FC<LoginViewProps> = ({ params }) => {
   };
 
   const handleExternalAuthentication = async (code: string, state: string) => {
-    const result = await loginByExternalPlugin(requestedExternalPluginId, {
+    await loginByExternalPlugin(requestedExternalPluginId, {
       code,
       state,
     });
     setRequestedExternalPluginId(null);
-    if (result && !result?.errors?.length) {
-      navigate(fallbackUri);
-      setFallbackUri(null);
-    }
+    navigate(fallbackUri);
+    setFallbackUri(null);
   };
 
   useEffect(() => {