Skip to content

Commit

Permalink
Update descriptions for gift card messages to be more descriptive (#1648
Browse files Browse the repository at this point in the history
)
  • Loading branch information
Cloud11PL committed Jan 11, 2022
1 parent 2055dbe commit 6c712af
Show file tree
Hide file tree
Showing 21 changed files with 181 additions and 180 deletions.
179 changes: 90 additions & 89 deletions locale/defaultMessages.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/giftCards/GiftCardBulkCreateDialog/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineMessages } from "react-intl";
export const giftCardBulkCreateDialogMessages = defineMessages({
title: {
defaultMessage: "Bulk Issue Gift Cards",
description: "bulk issue gift cards dialogtitle"
description: "bulk issue gift cards dialog title"
},
createdSuccessAlertTitle: {
defaultMessage: "Gift Cards Issued",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ import { defineMessages } from "react-intl";
export const giftCardCreateExpirySelectMessages = defineMessages({
expirySelectedLabel: {
defaultMessage: "Set gift card expiry date",
description: "GiftCarUpdateDetailsExpirySection expiry selected label"
description: "set expiry date selected label"
},
expiryPeriodLabel: {
defaultMessage: "Expires in",
description: "GiftCarUpdateDetailsExpirySection expiry period label"
description: "expires in label"
},
expiryDateLabel: {
defaultMessage: "Exact date",
description: "GiftCarUpdateDetailsExpirySection expiry date label"
description: "expiry date label"
},
expiryOnLabel: {
defaultMessage: "Will expire on:",
description: "GiftCarUpdateDetailsExpirySection expiry on label"
description: "expires on label"
}
});
2 changes: 1 addition & 1 deletion src/giftCards/GiftCardExportDialog/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ export const giftCardExportDialogMessages = defineMessages({
},
successAlertTitle: {
defaultMessage: "Exporting CSV",
description: "gift card export success alert title"
description: "gift card export csv success alert title"
}
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ import { defineMessages } from "react-intl";
export const giftCardExpirySettingsCard = defineMessages({
expiryDateSectionDescription: {
defaultMessage:
"You can set gift cards to expire after a certain time after their purchase. Remember that in some countries, gift cards expiry is prohibited by law."
"You can set gift cards to expire after a certain time after their purchase. Remember that in some countries, gift cards expiry is prohibited by law.",
description: "expiry date selection info message"
},
expiryDateTitle: {
defaultMessage: "Expiry date",
description: "section header"
description: "expiry date section header"
}
});
2 changes: 1 addition & 1 deletion src/giftCards/GiftCardSettings/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { defineMessages, IntlShape } from "react-intl";
export const giftCardSettingsPageMessages = defineMessages({
title: {
defaultMessage: "Gift Cards Settings",
description: "header"
description: "gift card settings header"
}
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,31 @@ import { defineMessages } from "react-intl";
export const giftCardResendCodeDialogMessages = defineMessages({
title: {
defaultMessage: "Resend code to customer",
description: "GiftCardResendCodeDialog title"
description: "resend code to customer title"
},
description: {
defaultMessage:
"Gift Card Code will be resent to email provided during checkout. You can provide a different email address if you want to:",
description: "GiftCardResendCodeDialog description"
description: "resend code to customer description"
},
consentCheckboxLabel: {
defaultMessage: "Yes, I want to send gift card to different address",
description: "GiftCardResendCodeDialog consentCheckboxLabel"
description: "consent to send gift card to different address checkbox label"
},
submitButtonLabel: {
defaultMessage: "Resend",
description: "GiftCardResendCodeDialog submitButtonLabel"
description: "resend button label"
},
emailInputPlaceholder: {
defaultMessage: "Provided email address",
description: "GiftCardResendCodeDialog emailInputPlaceholder"
description: "provided email input placeholder"
},
successResendAlertText: {
defaultMessage: "Successfully resent code to customer!",
description: "GiftCardResendCodeDialog successResendAlertText"
description: "resent code success message"
},
sendToChannelSelectLabel: {
defaultMessage: "Send to channel",
description: "ChannelPickerSelectField sendToChannelLabel"
description: "send to channel select label"
}
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,19 @@ import { defineMessages } from "react-intl";
export const giftCardUpdateBalanceDialogMessages = defineMessages({
title: {
defaultMessage: "Set balance",
description: "GiftCardUpdateDetailsCard set balance button label"
description: "set balance dialog title label"
},
subtitle: {
defaultMessage:
"What would you like to set cards balance to. When you change the balance both values will be changed",
description: "GiftCardUpdateDetailsCard set balance dialog subtitle"
description: "set balance dialog subtitle"
},
updatedSuccessAlertTitle: {
defaultMessage: "Successfully updated card balance",
description: "GiftCardUpdateDetailsCard update success alert title"
description: "card update success alert title"
},
changeButtonLabel: {
defaultMessage: "Change",
description:
"GiftCardUpdateDetailsCard set balance dialog change button label"
description: "change button label"
}
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ import { defineMessages } from "react-intl";
export const giftCardUpdateDetailsCardMessages = defineMessages({
title: {
defaultMessage: "Details",
description: "GiftCardUpdateDetailsCard title"
description: "details title"
},
setBalanceButtonLabel: {
defaultMessage: "set balance",
description: "GiftCardUpdateDetailsCard set balance button label"
description: "set balance button label"
},
cardBalanceLabel: {
defaultMessage: "Card Balance",
description: "GiftCardUpdateDetailsCard card balance label"
description: "card balance label"
},
tagInputLabel: {
defaultMessage: "Card Tag",
description: "GiftCardTagInput tag label"
description: "tag label"
}
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ import { defineMessages } from "react-intl";
export const giftCardExpirySelectMessages = defineMessages({
expiryDateCheckboxLabel: {
defaultMessage: "Gift card expires",
description: "GiftCarUpdateDetailsExpirySection expiry date checkbox label"
description: "expiry date checkbox label"
},
expiryDateLabel: {
defaultMessage: "Expiration date",
description: "GiftCarUpdateDetailsExpirySection expiry date label"
description: "expiration date label"
},
expiredOnLabel: {
defaultMessage: "Expired on {date}",
description: "GiftCarUpdateDetailsExpirySection expired on label"
description: "expired on label"
}
});
16 changes: 8 additions & 8 deletions src/giftCards/GiftCardUpdate/GiftCardUpdateInfoCard/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,34 +3,34 @@ import { defineMessages } from "react-intl";
export const giftCardUpdateInfoCardMessages = defineMessages({
title: {
defaultMessage: "Card information",
description: "GiftCardUpdateInfoCard title"
description: "info card title"
},
creationLabel: {
defaultMessage: "Creation",
description: "GiftCardUpdateInfoCard creation label"
description: "creation label"
},
orderNumberLabel: {
defaultMessage: "Order number",
description: "GiftCardUpdateInfoCard order number label"
description: "order number label"
},
productLabel: {
defaultMessage: "Product bought to get gift card",
description: "GiftCardUpdateInfoCard product label"
description: "product label"
},
issuedByLabel: {
defaultMessage: "Issued by",
description: "GiftCardUpdateInfoCard issued by label"
description: "issued by label"
},
issuedByAppLabel: {
defaultMessage: "Issued by app",
description: "GiftCardUpdateInfoCard issued by app label"
description: "issued by app label"
},
boughtByLabel: {
defaultMessage: "Bought by",
description: "GiftCardUpdateInfoCard bought by label"
description: "bought by label"
},
usedByLabel: {
defaultMessage: "Used by",
description: "GiftCardUpdateInfoCard used by label"
description: "used by label"
}
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,25 @@ import { defineMessages } from "react-intl";
export const giftCardEnableDisableSectionMessages = defineMessages({
successfullyEnabledTitle: {
defaultMessage: "Successfully enabled gift card",
description: "GiftCardEnableDisableSection enable success"
description: "success gift card enable message"
},
successfullyDisabledTitle: {
defaultMessage: "Successfully disabled gift card",
description: "GiftCardEnableDisableSection disable success"
description: "success gift card disable message"
}
});

export const giftCardUpdatePageHeaderMessages = defineMessages({
resendButtonLabel: {
defaultMessage: "Resend code",
description: "giftCardUpdatePageHeader resendButtonLabel"
description: "resend code label"
},
expiredStatusLabel: {
defaultMessage: "Expired",
description: "giftCardUpdatePageHeader expired status label"
description: "expired status label"
},
disabledStatusLabel: {
defaultMessage: "Disabled",
description: "giftCardUpdatePageHeader disabled status label"
description: "disabled status label"
}
});
4 changes: 2 additions & 2 deletions src/giftCards/GiftCardUpdate/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ import { defineMessages, IntlShape } from "react-intl";
export const giftCardUpdateDetailsCardMessages = defineMessages({
title: {
defaultMessage: "Details",
description: "GiftCardUpdateDetailsCard title"
description: "title"
}
});

const giftCardErrorMessages = defineMessages({
notFound: {
defaultMessage: "Couldn't find gift card",
description: "giftCardErrorMessages not found"
description: "gift card not found message"
}
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,21 @@ import { defineMessages } from "react-intl";
export const giftCardListFilterErrorMessages = defineMessages({
balanceAmount: {
defaultMessage: "Balance amount is missing",
description: "Filter balance amount error"
description: "balance amound missing error message"
},
balanceCurrency: {
defaultMessage: "Balance currency is missing",
description: "Filter balance currency error"
description: "balance curreny missing error message"
}
});

export const giftCardListSearchAndFiltersMessages = defineMessages({
searchPlaceholder: {
defaultMessage: "Search Gift Cards, e.g {exampleGiftCardCode}",
description: "gift card search placeholder"
description: "search gift card placeholder"
},
defaultTabLabel: {
defaultMessage: "All Gift Cards",
description: "gift card default tab label"
description: "all gift cards label"
}
});
Original file line number Diff line number Diff line change
Expand Up @@ -3,34 +3,34 @@ import { defineMessages } from "react-intl";
export const bulkEnableDisableSectionMessages = defineMessages({
enableLabel: {
defaultMessage: "Activate",
description: "GiftCardEnableDisableSection enable label"
description: "bulk activate label"
},
disableLabel: {
defaultMessage: "Deactivate",
description: "GiftCardEnableDisableSection enable label"
description: "bulk disable label"
},
deleteLabel: {
defaultMessage: "Delete",
description: "GiftCardEnableDisableSection enable label"
description: "bulk delete label"
},
successActivateAlertText: {
defaultMessage:
"Successfully activated gift {count,plural,one{card} other{cards}}",
description: "GiftCardEnableDisableSection success activate alert text"
description: "success activate alert message"
},
successDeactivateAlertText: {
defaultMessage:
"Successfully deactivated gift {count,plural,one{card} other{cards}}",
description: "GiftCardEnableDisableSection success activate alert text"
description: "success deactivate alert message"
},
errorActivateAlertText: {
defaultMessage:
"Error activating gift {count,plural,one{card} other{cards}}",
description: "GiftCardEnableDisableSection error activate alert text"
description: "error with activatation alert message"
},
errorDeactivateAlertText: {
defaultMessage:
"Errors deactivating gift {count,plural,one{card} other{cards}}",
description: "GiftCardEnableDisableSection error activate alert text"
description: "error with deactivatation alert message"
}
});
Loading

0 comments on commit 6c712af

Please sign in to comment.