Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated fields #1071

Merged
merged 5 commits into from
Apr 26, 2021
Merged

Drop deprecated fields #1071

merged 5 commits into from
Apr 26, 2021

Conversation

jwm0
Copy link
Contributor

@jwm0 jwm0 commented Apr 21, 2021

I want to merge this change because it drops all deprecated fields.

Additionally, following views were changed/altered to fit the current schema:

  1. Local apps now have an "Activate"/"Deactivate" button instead of a checkbox:
    image
  1. Order view now shows all applied discounts:
    image

PR intended to be tested with API branch: saleor/saleor#7199

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://saleor-1083-drop-deprecated-queries-and-mutations.api.saleor.rocks/graphql/

@patrys
Copy link
Member

patrys commented Apr 21, 2021

@github-actions github-actions bot temporarily deployed to saleor-1971-drop-deprecated-fields April 21, 2021 10:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1971-drop-deprecated-fields April 21, 2021 10:59 Inactive
@jwm0 jwm0 requested review from a team, dominik-zeglen, bmigirl and eCzerniak and removed request for a team April 21, 2021 11:46
@github-actions github-actions bot temporarily deployed to saleor-1971-drop-deprecated-fields April 21, 2021 11:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1971-drop-deprecated-fields April 21, 2021 11:48 Inactive
@github-actions github-actions bot requested a review from pwgryglak April 21, 2021 12:16
Copy link

@pwgryglak pwgryglak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add to this PR the feature with showing specific product discounts? I mean previous and actual price shown in orderlines.
Other than that looks great.

@jwm0
Copy link
Contributor Author

jwm0 commented Apr 21, 2021

Can we add to this PR the feature with showing specific product discounts? I mean previous and actual price shown in orderlines.
Other than that looks great.

@pwgryglak This should be done in a separate PR. The only reason I'm touching any UI in this PR is because some of those dropped fields had impact on the UI and fix was needed to fully complete the task.

@pwgryglak
Copy link

@jwm0 ok :(

@github-actions github-actions bot temporarily deployed to saleor-1971-drop-deprecated-fields April 22, 2021 11:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1971-drop-deprecated-fields April 22, 2021 11:43 Inactive
@github-actions github-actions bot temporarily deployed to saleor-1971-drop-deprecated-fields April 22, 2021 13:58 Inactive
@github-actions github-actions bot had a problem deploying to storybook saleor-1971-drop-deprecated-fields April 22, 2021 13:58 Failure
@github-actions github-actions bot temporarily deployed to saleor-1971-drop-deprecated-fields April 22, 2021 15:30 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1971-drop-deprecated-fields April 22, 2021 15:30 Inactive
@jwm0 jwm0 force-pushed the SALEOR-1971-drop-deprecated-fields branch from 7343c22 to 95c61ce Compare April 23, 2021 14:20
@github-actions github-actions bot temporarily deployed to saleor-1971-drop-deprecated-fields April 23, 2021 14:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1971-drop-deprecated-fields April 23, 2021 14:21 Inactive
* fix

* update stories
@github-actions github-actions bot temporarily deployed to saleor-1971-drop-deprecated-fields April 26, 2021 07:12 Inactive
@jwm0 jwm0 merged commit a83a245 into master Apr 26, 2021
@jwm0 jwm0 deleted the SALEOR-1971-drop-deprecated-fields branch April 26, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants