Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service worker #1073

Merged
merged 8 commits into from
Apr 26, 2021
Merged

Add service worker #1073

merged 8 commits into from
Apr 26, 2021

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds service worker, which caches images and is able to notify about new app version.

PR intended to be tested with API branch: master

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

@dominik-zeglen dominik-zeglen requested review from a team, orzechdev and jwm0 and removed request for a team April 21, 2021 11:33
@patrys
Copy link
Member

patrys commented Apr 21, 2021

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot temporarily deployed to saleor-1121-add-sw April 21, 2021 11:33 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1121-add-sw April 21, 2021 11:33 Inactive
@github-actions github-actions bot temporarily deployed to saleor-1121-add-sw April 21, 2021 12:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1121-add-sw April 21, 2021 12:10 Inactive
webpack.config.js Outdated Show resolved Hide resolved
@dominik-zeglen dominik-zeglen requested a review from jwm0 April 22, 2021 08:10
@github-actions github-actions bot temporarily deployed to saleor-1121-add-sw April 22, 2021 08:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1121-add-sw April 22, 2021 08:10 Inactive
src/hooks/useServiceWorker.ts Outdated Show resolved Hide resolved
src/hooks/useServiceWorker.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to saleor-1121-add-sw April 22, 2021 10:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1121-add-sw April 22, 2021 10:34 Inactive
@dominik-zeglen dominik-zeglen requested a review from jwm0 April 22, 2021 10:36
src/config.ts Show resolved Hide resolved
src/hooks/useServiceWorker.ts Outdated Show resolved Hide resolved
@dominik-zeglen dominik-zeglen requested a review from jwm0 April 22, 2021 10:47
@github-actions github-actions bot temporarily deployed to saleor-1121-add-sw April 22, 2021 10:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1121-add-sw April 22, 2021 10:48 Inactive
@github-actions github-actions bot temporarily deployed to saleor-1121-add-sw April 22, 2021 13:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1121-add-sw April 22, 2021 13:28 Inactive
@dominik-zeglen dominik-zeglen requested a review from jwm0 April 23, 2021 08:16
@github-actions github-actions bot temporarily deployed to saleor-1121-add-sw April 23, 2021 08:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1121-add-sw April 23, 2021 08:17 Inactive
@github-actions github-actions bot temporarily deployed to saleor-1121-add-sw April 26, 2021 09:46 Inactive
@dominik-zeglen dominik-zeglen merged commit d220914 into master Apr 26, 2021
@dominik-zeglen dominik-zeglen deleted the SALEOR-1121-add-sw branch April 26, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants