Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saleor 2183 Fix sortable chip style #1091

Merged
merged 1 commit into from
May 4, 2021
Merged

Saleor 2183 Fix sortable chip style #1091

merged 1 commit into from
May 4, 2021

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Apr 29, 2021 •
edited
Loading

I want to merge this change because... it fixes sortable chip style in dark mode.

PR intended to be tested with API branch: master

Screenshots

before:
Zrzut ekranu 2021-04-29 o 13 22 57

after:
Zrzut ekranu 2021-04-29 o 13 14 28

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

@patrys
Copy link
Member

patrys commented Apr 29, 2021

Task linked: SALEOR-2183 Invalid style in attributes panel in Product View.

@github-actions github-actions bot temporarily deployed to saleor-2183-fix-sortable-chip-style April 29, 2021 11:20 Inactive
@orzechdev orzechdev changed the title SALEOR-2183 Fix sortable chip style Saleor 2183 Fix sortable chip style Apr 29, 2021
@orzechdev orzechdev marked this pull request as ready for review April 29, 2021 11:40
@github-actions github-actions bot requested a review from pwgryglak April 29, 2021 11:41
@orzechdev orzechdev requested review from a team, dominik-zeglen and bmigirl and removed request for a team April 29, 2021 11:41
@orzechdev orzechdev merged commit e2a80e4 into master May 4, 2021
@orzechdev orzechdev deleted the SALEOR-2183-fix-sortable-chip-style branch May 4, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmigirl bmigirl bmigirl approved these changes

@dominik-zeglen dominik-zeglen dominik-zeglen approved these changes

@pwgryglak pwgryglak Awaiting requested review from pwgryglak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orzechdev @patrys @dominik-zeglen @bmigirl