Change usages of order error order line prop #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmigirl
requested review from
eCzerniak,
jwm0,
a team and
dominik-zeglen
and removed request for
a team
github-actions
bot
temporarily deployed
to
saleor-3599-change-usages-of-order-error-order-line-prop
github-actions
bot
temporarily deployed
to
storybook saleor-3599-change-usages-of-order-error-order-line-prop
dominik-zeglen
changed the title
dominik-zeglen
suggested changes
Jun 18, 2021
| @@ -430,7 +430,7 @@ const OrderFulfillPage: React.FC<OrderFulfillPageProps> = props => { | |||
| !!errors?.find( | |||
| err => | |||
| err.warehouse === warehouse.id && | |||
| err.orderLine === line.id && | |||
| err.orderLines[0] === line.id && | |||
There was a problem hiding this comment.
I'm pretty sure you should search in whole array, not just 0th index
There was a problem hiding this comment.
Jus to chip in - this is a very temporary workaround to make backend changes mergeable and further frontend implementation will be worked on immediately after this, but I agree this is a very low-effort change so let's change it now
jwm0
suggested changes
Jun 18, 2021
| @@ -430,7 +430,7 @@ const OrderFulfillPage: React.FC<OrderFulfillPageProps> = props => { | |||
| !!errors?.find( | |||
| err => | |||
| err.warehouse === warehouse.id && | |||
| err.orderLine === line.id && | |||
| err.orderLines[0] === line.id && | |||
There was a problem hiding this comment.
Jus to chip in - this is a very temporary workaround to make backend changes mergeable and further frontend implementation will be worked on immediately after this, but I agree this is a very low-effort change so let's change it now
github-actions
bot
temporarily deployed
to
saleor-3599-change-usages-of-order-error-order-line-prop
dominik-zeglen
approved these changes
Jun 18, 2021
jwm0
approved these changes
Jun 18, 2021
|
Task linked: SALEOR-3599 Change usages of orderLine to orderLines |
eCzerniak
approved these changes
Jun 21, 2021
jwm0
deleted the
SALEOR-3599/change-usages-of-order-error-order-line-prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it uses schema changes to match this PR
PR intended to be tested with API branch:
Screenshots
Pull Request Checklist
[data-test-id]are added for new elementsTest environment config
API_URI=https://saleor-2294-update-draft-order-validation.api.saleor.rocks/graphql/