Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with modals containing invalid/redundant scrolls #1240

Merged

Conversation

kamilpastuszka
Copy link
Contributor

@kamilpastuszka kamilpastuszka commented Jul 19, 2021

I want to merge this change to fix issue with invalid/redundant scrolls for some modals.

Requirements for testing:

Prior to testing, a respective Macaw-UI version needs to be installed, as some of the changes have been moved there. They are now available under the hash commit 73dcbb3.
It can be done via the following command:

npm i https://github.com/mirumee/macaw-ui.git#73dcbb3


PR intended to be tested with API branch:


Examples of usage:

Assign Channels to Products

image

Add Product to Draft Order

image

Assign Collection to Sales

image

Shipping - Assign Countries

image

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

@patrys
Copy link
Member

patrys commented Jul 19, 2021

@github-actions github-actions bot temporarily deployed to saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 19, 2021 10:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 19, 2021 10:52 Inactive
@github-actions github-actions bot temporarily deployed to saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 19, 2021 11:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 19, 2021 11:05 Inactive
@github-actions github-actions bot temporarily deployed to saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 19, 2021 11:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 19, 2021 11:52 Inactive
@kamilpastuszka kamilpastuszka force-pushed the SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls branch from 90dd6ca to 008f229 Compare July 19, 2021 12:03
@github-actions github-actions bot temporarily deployed to saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 19, 2021 12:04 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 19, 2021 12:04 Inactive
@kamilpastuszka kamilpastuszka marked this pull request as draft July 19, 2021 12:32
@kamilpastuszka kamilpastuszka requested review from a team, bmigirl and SektorDV and removed request for a team July 22, 2021 10:19
@kamilpastuszka kamilpastuszka marked this pull request as ready for review July 22, 2021 10:21
@kamilpastuszka kamilpastuszka force-pushed the SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls branch from a0db0fd to 83b7a2f Compare July 22, 2021 13:24
@kamilpastuszka kamilpastuszka force-pushed the SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls branch from 83b7a2f to 3628810 Compare July 30, 2021 10:10
@github-actions github-actions bot temporarily deployed to saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 30, 2021 10:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 30, 2021 10:10 Inactive
@kamilpastuszka kamilpastuszka requested a review from eCzerniak July 30, 2021 10:11
@github-actions github-actions bot temporarily deployed to saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 30, 2021 10:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls July 30, 2021 10:18 Inactive
@github-actions github-actions bot temporarily deployed to saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls August 11, 2021 08:39 Inactive
@jwm0 jwm0 merged commit 8064b35 into master Aug 11, 2021
@jwm0 jwm0 deleted the SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls branch August 11, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants