-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue with modals containing invalid/redundant scrolls #1240
Merged
jwm0
merged 6 commits into
master
from
SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls
Aug 11, 2021
Merged
Fixed issue with modals containing invalid/redundant scrolls #1240
jwm0
merged 6 commits into
master
from
SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 19, 2021 10:52
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 19, 2021 10:52
Inactive
github-actions
bot
temporarily deployed
to
saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 19, 2021 11:05
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 19, 2021 11:05
Inactive
github-actions
bot
temporarily deployed
to
saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 19, 2021 11:52
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 19, 2021 11:52
Inactive
kamilpastuszka
force-pushed
the
SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls
branch
from
July 19, 2021 12:03
90dd6ca
to
008f229
Compare
github-actions
bot
temporarily deployed
to
saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 19, 2021 12:04
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 19, 2021 12:04
Inactive
kamilpastuszka
requested review from
a team,
bmigirl and
SektorDV
and removed request for
a team
July 22, 2021 10:19
kamilpastuszka
force-pushed
the
SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls
branch
from
July 22, 2021 13:24
a0db0fd
to
83b7a2f
Compare
bmigirl
approved these changes
Jul 23, 2021
SektorDV
approved these changes
Jul 23, 2021
kamilpastuszka
force-pushed
the
SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls
branch
from
July 30, 2021 10:10
83b7a2f
to
3628810
Compare
github-actions
bot
temporarily deployed
to
saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 30, 2021 10:10
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 30, 2021 10:10
Inactive
github-actions
bot
temporarily deployed
to
saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 30, 2021 10:18
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
July 30, 2021 10:18
Inactive
eCzerniak
approved these changes
Aug 3, 2021
…-or-redundant-scrolls
github-actions
bot
temporarily deployed
to
saleor-2649-assign-modals-contains-invalid-or-redundant-scrolls
August 11, 2021 08:39
Inactive
jwm0
deleted the
SALEOR-2649-Assign-modals-contains-invalid-or-redundant-scrolls
branch
August 11, 2021 09:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change to fix issue with invalid/redundant scrolls for some modals.
Requirements for testing:
Prior to testing, a respective Macaw-UI version needs to be installed, as some of the changes have been moved there. They are now available under the hash commit 73dcbb3.
It can be done via the following command:
PR intended to be tested with API branch:
Examples of usage:
Assign Channels to Products
Add Product to Draft Order
Assign Collection to Sales
Shipping - Assign Countries
Pull Request Checklist
[data-test-id]
are added for new elementsTest environment config
API_URI=https://qa.staging.saleor.cloud/graphql/