Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve limit messages #1274

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Improve limit messages #1274

merged 1 commit into from
Aug 10, 2021

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it translates messages and adds alert to order draft list as well.

PR intended to be tested with API branch: master

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

@dominik-zeglen dominik-zeglen requested review from a team, kamilpastuszka and SektorDV and removed request for a team August 5, 2021 12:15
@patrys
Copy link
Member

patrys commented Aug 5, 2021

Task linked: CLOUD-879 Handle order hard-limitation in Dashboard

@github-actions github-actions bot temporarily deployed to cloud-879-order-limits August 5, 2021 12:16 Inactive
@dominik-zeglen dominik-zeglen merged commit 6d3e346 into master Aug 10, 2021
@dominik-zeglen dominik-zeglen deleted the CLOUD-879-order-limits branch August 10, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SektorDV SektorDV SektorDV approved these changes

@kamilpastuszka kamilpastuszka kamilpastuszka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominik-zeglen @patrys @kamilpastuszka @SektorDV