Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text attribute for product and page translations #1276

Conversation

kamilpastuszka
Copy link
Contributor

I want to merge this to enable translation for text attributes.

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

@patrys
Copy link
Member

patrys commented Aug 6, 2021

@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 08:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 08:37 Inactive
@kamilpastuszka kamilpastuszka marked this pull request as draft August 6, 2021 08:38
@kamilpastuszka kamilpastuszka changed the title initial commit Add text attribute for product and page translations Aug 6, 2021
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 12:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 12:09 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 12:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 12:35 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 13:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 13:06 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 13:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 13:48 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 13:59 Inactive
@github-actions github-actions bot had a problem deploying to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 13:59 Failure
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 14:20 Inactive
@github-actions github-actions bot had a problem deploying to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 14:20 Failure
@kamilpastuszka kamilpastuszka force-pushed the SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text branch from 15a2250 to 23572ab Compare August 6, 2021 14:30
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 14:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 14:32 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 15:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 6, 2021 15:20 Inactive
@kamilpastuszka kamilpastuszka force-pushed the SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text branch from 576ac39 to 8efb132 Compare August 9, 2021 06:08
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 06:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 06:18 Inactive
@kamilpastuszka kamilpastuszka force-pushed the SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text branch from 98fbf51 to 8efb132 Compare August 9, 2021 06:38
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 06:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 06:41 Inactive
@kamilpastuszka kamilpastuszka force-pushed the SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text branch from 5db3c85 to e889a7b Compare August 9, 2021 07:09
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 07:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 12:18 Inactive
@jwm0
Copy link
Contributor

jwm0 commented Aug 9, 2021

@kamilpastuszka let's freeze the work here, please refer to all unresolved comments in a different PR

@jwm0 jwm0 dismissed bmigirl’s stale review August 9, 2021 12:27

Rest of comments will be resolved in another PR

@jwm0 jwm0 force-pushed the SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text branch from 57669db to 662d9c6 Compare August 9, 2021 12:56
@jwm0 jwm0 force-pushed the SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text branch from 662d9c6 to 33570c0 Compare August 9, 2021 14:29
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 14:30 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 14:30 Inactive
@github-actions github-actions bot temporarily deployed to saleor-3736-product-and-page-translations-missing-attributes-of August 9, 2021 14:49 Inactive
@jwm0 jwm0 merged commit 034eea0 into master Aug 9, 2021
@jwm0 jwm0 deleted the SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text branch August 9, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants