-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text attribute for product and page translations #1276
Merged
jwm0
merged 18 commits into
master
from
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
Aug 9, 2021
Merged
Add text attribute for product and page translations #1276
jwm0
merged 18 commits into
master
from
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
Aug 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 08:37
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 08:37
Inactive
kamilpastuszka
changed the title
initial commit
Add text attribute for product and page translations
Aug 6, 2021
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 12:09
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 12:09
Inactive
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 12:35
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 12:35
Inactive
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 13:06
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 13:06
Inactive
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 13:48
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 13:48
Inactive
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 13:59
Inactive
github-actions
bot
had a problem deploying
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 13:59
Failure
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 14:20
Inactive
github-actions
bot
had a problem deploying
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 14:20
Failure
kamilpastuszka
force-pushed
the
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
branch
from
August 6, 2021 14:30
15a2250
to
23572ab
Compare
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 14:32
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 14:32
Inactive
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 15:20
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 6, 2021 15:20
Inactive
kamilpastuszka
force-pushed
the
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
branch
from
August 9, 2021 06:08
576ac39
to
8efb132
Compare
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 06:18
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 06:18
Inactive
kamilpastuszka
force-pushed
the
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
branch
from
August 9, 2021 06:38
98fbf51
to
8efb132
Compare
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 06:41
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 06:41
Inactive
kamilpastuszka
force-pushed
the
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
branch
from
August 9, 2021 07:09
5db3c85
to
e889a7b
Compare
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 07:15
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 12:18
Inactive
@kamilpastuszka let's freeze the work here, please refer to all unresolved comments in a different PR |
jwm0
approved these changes
Aug 9, 2021
jwm0
dismissed
bmigirl’s stale review
August 9, 2021 12:27
Rest of comments will be resolved in another PR
jwm0
force-pushed
the
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
branch
from
August 9, 2021 12:56
57669db
to
662d9c6
Compare
jwm0
force-pushed
the
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
branch
from
August 9, 2021 14:29
662d9c6
to
33570c0
Compare
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 14:30
Inactive
github-actions
bot
temporarily deployed
to
storybook saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 14:30
Inactive
github-actions
bot
temporarily deployed
to
saleor-3736-product-and-page-translations-missing-attributes-of
August 9, 2021 14:49
Inactive
jwm0
deleted the
SALEOR-3736-Product-and-page-translations-missing-attributes-of-type-text
branch
August 9, 2021 14:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this to enable translation for text attributes.
PR intended to be tested with API branch:
Screenshots
Pull Request Checklist
[data-test-id]
are added for new elementsTest environment config
API_URI=https://master.staging.saleor.cloud/graphql/