Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product variant translation view #1285

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

jwm0
Copy link
Contributor

@jwm0 jwm0 commented Aug 10, 2021

I want to merge this change because it adds support for translating product variants.

PR intended to be tested with API branch:

Screenshots

image

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

@github-actions github-actions bot temporarily deployed to saleor-4164-add-missing-product-variant-translation-page August 10, 2021 09:51 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-4164-add-missing-product-variant-translation-page August 10, 2021 09:51 Inactive
@github-actions github-actions bot temporarily deployed to saleor-4164-add-missing-product-variant-translation-page August 10, 2021 13:55 Inactive
@jwm0 jwm0 marked this pull request as ready for review August 10, 2021 13:55
@github-actions github-actions bot requested a review from pwgryglak August 10, 2021 14:01
@jwm0 jwm0 merged commit b65a632 into master Aug 10, 2021
@jwm0 jwm0 deleted the SALEOR-4164/add-missing-product-variant-translation-page branch August 10, 2021 14:38
@patrys
Copy link
Member

patrys commented Aug 12, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants