Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optional chaining to ids #1305

Merged
merged 3 commits into from
Aug 20, 2021
Merged

add optional chaining to ids #1305

merged 3 commits into from
Aug 20, 2021

Conversation

SektorDV
Copy link
Contributor

I want to merge this change because it fixes the dashboard crash when no channels exist

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://test30.staging.saleor.cloud/graphql/

@SektorDV SektorDV requested review from jwm0, a team and bmigirl and removed request for a team August 19, 2021 10:00
@patrys
Copy link
Member

patrys commented Aug 19, 2021

Task linked: SALEOR-4216 Dashboard blows up when no channels exist

@SektorDV SektorDV requested a review from eCzerniak August 19, 2021 10:00
@github-actions github-actions bot temporarily deployed to saleor-4216-3-0-dashboard-crash-when-no-channels-exist August 19, 2021 10:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-4216-3-0-dashboard-crash-when-no-channels-exist August 19, 2021 10:01 Inactive
@SektorDV SektorDV added the 3.0 Related to Saleor 3.0 label Aug 19, 2021
@github-actions github-actions bot temporarily deployed to saleor-4216-3-0-dashboard-crash-when-no-channels-exist August 19, 2021 12:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-4216-3-0-dashboard-crash-when-no-channels-exist August 19, 2021 12:58 Inactive
@github-actions github-actions bot temporarily deployed to saleor-4216-3-0-dashboard-crash-when-no-channels-exist August 19, 2021 16:09 Inactive
@jwm0 jwm0 merged commit 005a65e into 3.0 Aug 20, 2021
@jwm0 jwm0 deleted the SALEOR-4216/3.0/dashboard-crash-when-no-channels-exist branch August 20, 2021 07:15
SektorDV added a commit that referenced this pull request Aug 20, 2021
@SektorDV
Fix dashboard crashing when no channels exist (#1305)
4144885 
* add optional chaining to ids

* lint fix

* channel value test fix
SektorDV added a commit that referenced this pull request Aug 20, 2021
@SektorDV
Fix dashboard crashing when no channels exist (#1305)
739a483 
* add optional chaining to ids

* lint fix

* channel value test fix
jwm0 pushed a commit that referenced this pull request Aug 20, 2021
@SektorDV
Fix dashboard crash when no channels exist (#1311)
c5adcda 
* channel value test fix

* update snapshots

* Fix dashboard crashing when no channels exist (#1305)

* add optional chaining to ids

* lint fix

* channel value test fix

* Fix dashboard crashing when no channels exist (#1305)

* add optional chaining to ids

* lint fix

* channel value test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eCzerniak eCzerniak eCzerniak approved these changes

@jwm0 jwm0 jwm0 approved these changes

@bmigirl bmigirl Awaiting requested review from bmigirl

Assignees
No one assigned
Labels
3.0 Related to Saleor 3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SektorDV @patrys @jwm0 @eCzerniak