Fix creating simple products without categories #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SektorDV
requested review from
eCzerniak,
a team,
dominik-zeglen and
bmigirl
and removed request for
a team
github-actions
bot
temporarily deployed
to
saleor-3606-3-0-creating-simple-products-without-categories
| @@ -312,7 +311,8 @@ function useProductCreateForm( | |||
| data.channelListings.some( | |||
| channel => | |||
| validatePrice(channel.price) || validateCostPrice(channel.costPrice) | |||
| )); | |||
| ) || | |||
| !data.category); | |||
There was a problem hiding this comment.
This is quite complicated. Maybe it should be extracted to separate function shouldDisable or something?
There was a problem hiding this comment.
wouldn't that be redundant though? right now it's a boolean calculated based on a number of conditions, so pretty much it does exactly what a function would do. how would this benefit from having its value returned from a function?
dominik-zeglen
approved these changes
Aug 27, 2021
eCzerniak
approved these changes
Aug 27, 2021
bmigirl
suggested changes
Aug 27, 2021
| @@ -312,7 +311,8 @@ function useProductCreateForm( | |||
| data.channelListings.some( | |||
| channel => | |||
| validatePrice(channel.price) || validateCostPrice(channel.costPrice) | |||
| )); | |||
| ) || | |||
| !data.category); | |||
dominik-zeglen
approved these changes
Aug 31, 2021
| @@ -312,7 +311,8 @@ function useProductCreateForm( | |||
| data.channelListings.some( | |||
| channel => | |||
| validatePrice(channel.price) || validateCostPrice(channel.costPrice) | |||
| )); | |||
| ) || | |||
| !data.category); | |||
orzechdev
approved these changes
Aug 31, 2021
jwm0
changed the title
jwm0
deleted the
SALEOR-3606/3.0/creating-simple-products-without-categories
branch
jwm0
pushed a commit
that referenced
this pull request
Sep 3, 2021
5 tasks
jwm0
added a commit
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it disables the save button on product creator when a category has not been set for the created product (the backend expects this).
Pull Request Checklist
[data-test-id]are added for new elementsTest environment config
API_URI=https://master.staging.saleor.cloud/graphql/