Add channel picker product details #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
saleor-4300-3-0-add-channel-picker-product-details
github-actions
bot
temporarily deployed
to
storybook saleor-4300-3-0-add-channel-picker-product-details
github-actions
bot
temporarily deployed
to
saleor-4300-3-0-add-channel-picker-product-details
github-actions
bot
temporarily deployed
to
storybook saleor-4300-3-0-add-channel-picker-product-details
github-actions
bot
temporarily deployed
to
saleor-4300-3-0-add-channel-picker-product-details
dominik-zeglen
approved these changes
Sep 3, 2021
pwgryglak
approved these changes
Sep 3, 2021
eCzerniak
approved these changes
Sep 3, 2021
jwm0
added a commit
that referenced
this pull request
Sep 3, 2021
* Enable channel picker on product details page * Add channel picker to product details * Simplify category details page * Update snapshots and translations * Update types * Update testId, bump macaw-ui
5 tasks
jwm0
added a commit
that referenced
this pull request
Sep 3, 2021
* Add channel picker product details (#1353) * Enable channel picker on product details page * Add channel picker to product details * Simplify category details page * Update snapshots and translations * Update types * Update testId, bump macaw-ui * Update snapshots, types and schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it adds a channel picker to Product Details and simplifies the query/view of category details. New component is introduced called
InternalLinkwhich will be used in upcoming refactor to move all navigation actions fromonClick.PR intended to be tested with API branch: master/3.0
Screenshots
Pull Request Checklist
[data-test-id]are added for new elementsTest environment config
API_URI=https://master.staging.saleor.cloud/graphql/