Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailing configuration #222

Merged
merged 11 commits into from
Oct 24, 2019
Merged

Add mailing configuration #222

merged 11 commits into from
Oct 24, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds mailing configuration.

Screenshots

Screenshot 2019-10-21 at 16 20 55

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #222 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   73.97%   74.06%   +0.09%     
==========================================
  Files         588      589       +1     
  Lines        6143     6161      +18     
  Branches     1033     1035       +2     
==========================================
+ Hits         4544     4563      +19     
  Misses       1417     1417              
+ Partials      182      181       -1
Impacted Files Coverage Δ
src/components/ImageUpload/ImageUpload.tsx 90% <ø> (ø) ⬆️
src/siteSettings/fixtures.ts 100% <ø> (ø) ⬆️
src/theme.ts 100% <ø> (ø) ⬆️
...s/components/SiteSettingsPage/SiteSettingsPage.tsx 100% <100%> (ø) ⬆️
...torybook/stories/categories/CategoryUpdatePage.tsx 61.11% <100%> (ø) ⬆️
...torybook/stories/siteSettings/SiteSettingsPage.tsx 60% <100%> (ø) ⬆️
...onents/SiteSettingsMailing/SiteSettingsMailing.tsx 100% <100%> (ø)
...mponents/CategoryBackground/CategoryBackground.tsx 92.3% <0%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5131c50...9cb5c4c. Read the comment docs.

@dominik-zeglen dominik-zeglen merged commit 7102e70 into master Oct 24, 2019
@dominik-zeglen dominik-zeglen deleted the add/mail-config branch October 24, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants