Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove semver logic from navigator & autohide banner #3584

Merged
merged 2 commits into from
Apr 28, 2023
Merged

fix: remove semver logic from navigator & autohide banner #3584

merged 2 commits into from
Apr 28, 2023

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Apr 28, 2023 •
edited
Loading

I want to merge this change because...

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants
  23. payments

CONTAINERS=6

@github-actions github-actions bot temporarily deployed to fix-navigator-banner April 28, 2023 06:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook fix-navigator-banner April 28, 2023 06:55 Inactive
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review April 28, 2023 07:00
@github-actions github-actions bot temporarily deployed to fix-navigator-banner April 28, 2023 07:01 Inactive
@krzysztofzuraw krzysztofzuraw added the run e2e Runs cypress end-to-end tests label Apr 28, 2023
@krzysztofzuraw krzysztofzuraw changed the title fix: remove semver logic from navigator fix: remove semver logic from navigator & autohide banner Apr 28, 2023
@wojteknowacki wojteknowacki self-requested a review April 28, 2023 09:22
@krzysztofzuraw krzysztofzuraw requested review from a team, andrzejewsky and poulch and removed request for a team April 28, 2023 09:24
@andrzejewsky andrzejewsky mentioned this pull request Apr 28, 2023
Closed
28 tasks
@krzysztofzuraw krzysztofzuraw merged commit cb3f7d9 into main Apr 28, 2023
@krzysztofzuraw krzysztofzuraw deleted the fix/navigator-banner branch April 28, 2023 11:37
andrzejewsky pushed a commit that referenced this pull request May 2, 2023
@krzysztofzuraw @andrzejewsky
Remove semver logic from navigator & autohide banner (#3584)
55eb295
krzysztofzuraw added a commit that referenced this pull request May 11, 2023
@krzysztofzuraw
Remove semver logic from navigator & autohide banner (#3584)
694bd69
krzysztofzuraw added a commit that referenced this pull request May 11, 2023
@krzysztofzuraw
Remove semver logic from navigator & autohide banner (#3584)
bf6253e
krzysztofzuraw added a commit that referenced this pull request May 11, 2023
@krzysztofzuraw
Remove semver logic from navigator & autohide banner (#3584)
c010fc3
krzysztofzuraw added a commit that referenced this pull request May 11, 2023
@krzysztofzuraw
Remove semver logic from navigator & autohide banner (#3584)
12b55a4
krzysztofzuraw added a commit that referenced this pull request May 11, 2023
@krzysztofzuraw
Remove semver logic from navigator & autohide banner (#3584)
58e61ab
@byronrode byronrode mentioned this pull request Jul 18, 2023
Merged
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojteknowacki wojteknowacki wojteknowacki approved these changes

@poulch poulch poulch approved these changes

@andrzejewsky andrzejewsky andrzejewsky approved these changes

Assignees
No one assigned
Labels
run e2e Runs cypress end-to-end tests
Projects
Dashboard
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krzysztofzuraw @andrzejewsky @poulch @wojteknowacki