Remove misleading currency caption #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested a deployment
to
storybook copy-adjustments
timuric
changed the title
andrzejewsky
previously approved these changes
May 11, 2023
krzysztofzuraw
previously approved these changes
May 11, 2023
|
|
krzysztofzuraw
previously approved these changes
May 30, 2023
|
@michalina-graczyk good catch! Removed it as well |
krzysztofzuraw
approved these changes
Jun 6, 2023
Droniu
approved these changes
Jun 6, 2023
andrzejewsky
added a commit
that referenced
this pull request
Jun 20, 2023
* Remove misleading voucher value caption * Remove misleading order value caption * Remove misleading sale value caption * Remove misleading pricing card value caption * Remove misleading variant pricing card value caption * Extract messages * Update messages --------- Co-authored-by: andrzejewsky <vox3r69@gmail.com>
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove misleading description
PR intended to be tested with API branch:
Screenshots
Voucher screen
Before:
After :
Before:
After:
Before:
After:
Before:
After:
Before:
After:
Pull Request Checklist
[data-test-id]are added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=1