Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate macaw ui to new spacing scale #3674

Merged
merged 2 commits into from
May 24, 2023

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented May 19, 2023

I want to merge this change because it introduces new spacing scale in dashboard.

See PR in MacawUI: saleor/macaw-ui#437

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants
  23. payments

CONTAINERS=1

@github-actions github-actions bot temporarily deployed to feat-migrate-macaw-ui-new-spacing May 19, 2023 10:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook feat-migrate-macaw-ui-new-spacing May 19, 2023 10:55 Inactive
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review May 19, 2023 11:22
@krzysztofzuraw krzysztofzuraw requested review from a team, andrzejewsky and poulch and removed request for a team May 19, 2023 11:22
poulch
poulch previously approved these changes May 19, 2023
andrzejewsky
andrzejewsky previously approved these changes May 22, 2023
@krzysztofzuraw krzysztofzuraw dismissed stale reviews from andrzejewsky and poulch via 9fb220b May 22, 2023 10:40
@krzysztofzuraw krzysztofzuraw requested review from a team, andrzejewsky and poulch May 22, 2023 10:40
@github-actions github-actions bot temporarily deployed to feat-migrate-macaw-ui-new-spacing May 22, 2023 10:41 Inactive
@krzysztofzuraw krzysztofzuraw merged commit 76cde7c into main May 24, 2023
@krzysztofzuraw krzysztofzuraw deleted the feat/migrate-macaw-ui-new-spacing branch May 24, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants