Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test - test nightly workflow - scheduled tests run only on chrome #3731

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

wojteknowacki
Copy link
Member

@wojteknowacki wojteknowacki commented Jun 6, 2023

Removed Firefox job from scheduled nightly workflow

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants
  23. payments

CONTAINERS=1

@wojteknowacki wojteknowacki requested a review from a team as a code owner June 6, 2023 09:00
@wojteknowacki wojteknowacki requested a review from karola312 June 6, 2023 09:00
@github-actions github-actions bot temporarily deployed to test-remove-firefox-job-from-ci June 6, 2023 09:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook test-remove-firefox-job-from-ci June 6, 2023 09:00 Inactive
@karola312
Copy link
Member

On workflow dispatch this step work fine - https://cloud.cypress.io/projects/51ef7c/runs/4628/
There are fails while we running it for all test cases nightly. I suggest to just change this fragment, and on nightly run tests only via chrome - https://github.com/saleor/saleor-dashboard/pull/3731/files#diff-dfb781fe9d1a5b555da7bebb21f44b6cdfff28cd83d2bb25e234bd6169a06875R143
This way we could still select firefox if we need to run additional tests

@wojteknowacki
Copy link
Member Author

@mwidera we decided to leave the job since we can use it manually later. When it comes to image comments - it changes the node version to 16 which might cause plenty of issues. So the only change is scheduled job picker to use chrome

@wojteknowacki wojteknowacki changed the title test - removed firefox job from test nightly workflow test - test nightly workflow - scheduled tests run only on chrome Jun 6, 2023
@wojteknowacki wojteknowacki merged commit 3c3e6f4 into main Jun 6, 2023
@wojteknowacki wojteknowacki deleted the test-remove-firefox-job-from-ci branch June 6, 2023 12:02
andrzejewsky pushed a commit that referenced this pull request Jun 20, 2023
)

* test - removed firefox job from test nightly workflow

* Revert "test - removed firefox job from test nightly workflow"

This reverts commit 6cb0bb4.

* brought back job since we can use it manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants