Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Category listing datagrid #3760

Merged
merged 25 commits into from
Jul 4, 2023
Merged

Category listing datagrid #3760

merged 25 commits into from
Jul 4, 2023

Conversation

poulch
Copy link
Member

@poulch poulch commented Jun 15, 2023 •
edited by wojteknowacki
Loading

closes #3755

Replace all tables with datagrid, that include subcategories and product tables inside category detail page.

Screenshots

Before After
Screenshot 2023-06-16 at 10 08 45 Screenshot 2023-06-16 at 10 08 56
Before After
Screenshot 2023-06-16 at 10 12 01 Screenshot 2023-06-16 at 10 12 13
Before After
Screenshot 2023-06-16 at 10 15 13 Screenshot 2023-06-16 at 10 15 21

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants
  23. payments

CONTAINERS=6

@github-actions github-actions bot temporarily deployed to 3755-category-listing-datagrid June 15, 2023 14:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3755-category-listing-datagrid June 15, 2023 14:48 Inactive
@github-actions github-actions bot temporarily deployed to 3755-category-listing-datagrid June 16, 2023 08:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3755-category-listing-datagrid June 16, 2023 08:01 Inactive
@poulch poulch changed the title 3755 category listing datagrid Category listing datagrid Jun 19, 2023
@poulch poulch marked this pull request as ready for review June 20, 2023 08:31
@poulch poulch requested review from a team, andrzejewsky and Droniu June 20, 2023 08:31
@github-actions github-actions bot temporarily deployed to 3755-category-listing-datagrid June 23, 2023 08:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3755-category-listing-datagrid June 23, 2023 08:56 Inactive
andrzejewsky
andrzejewsky previously approved these changes Jun 27, 2023
View reviewed changes
krzysztofzuraw
krzysztofzuraw previously approved these changes Jun 27, 2023
View reviewed changes
@andrzejewsky andrzejewsky self-requested a review June 27, 2023 11:51
andrzejewsky
andrzejewsky previously approved these changes Jun 27, 2023
View reviewed changes
krzysztofzuraw
krzysztofzuraw previously approved these changes Jun 27, 2023
View reviewed changes
@poulch poulch added the run chromatic Run Chromatic visual tests on PR label Jun 28, 2023
@wojteknowacki wojteknowacki added the run e2e Runs cypress end-to-end tests label Jul 3, 2023
@wojteknowacki
Copy link
Member

wojteknowacki commented Jul 3, 2023 •
edited
Loading

When the subcategories amount exceeds 20 ( request sent with first 20 items ) error banner shows up in two cases:

  • go to the next page of the pagination
  • opening the subcategory detail page from the grid
Nagranie.z.ekranu.2023-07-3.o.09.37.53.mov
Nagranie.z.ekranu.2023-07-3.o.09.34.52.mov

Steps to reproduce:

  • make sure there are more than 20 subcategories added to the category
  • go to the second pagination page
    The error should be visible
  • entering subcategory details
    The error should be visible

@wojteknowacki wojteknowacki dismissed stale reviews from krzysztofzuraw and andrzejewsky via 76d0a34 July 3, 2023 09:57
@github-actions github-actions bot temporarily deployed to 3755-category-listing-datagrid July 3, 2023 09:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3755-category-listing-datagrid July 3, 2023 09:57 Inactive
@github-actions github-actions bot temporarily deployed to 3755-category-listing-datagrid July 3, 2023 12:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3755-category-listing-datagrid July 3, 2023 12:48 Inactive
@github-actions github-actions bot temporarily deployed to 3755-category-listing-datagrid July 3, 2023 13:52 Inactive
@wojteknowacki wojteknowacki self-requested a review July 4, 2023 07:03
@poulch poulch added run chromatic Run Chromatic visual tests on PR and removed run chromatic Run Chromatic visual tests on PR labels Jul 4, 2023
Droniu
Droniu approved these changes Jul 4, 2023
View reviewed changes
src/categories/views/CategoryDetails.tsx
displayQuantity: (
<strong>{maybe(() => params.ids.length)}</strong>
<strong>{maybe(() => selectedCategoryRowIds.length)}</strong>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick if you're touching lines with maybe it might be good to replace it with optional chaining / nullish coalescing

@poulch poulch merged commit b4f11ef into main Jul 4, 2023
@poulch poulch deleted the 3755-category-listing-datagrid branch July 4, 2023 07:23
@poulch poulch restored the 3755-category-listing-datagrid branch July 1, 2024 11:27
@poulch poulch deleted the 3755-category-listing-datagrid branch July 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojteknowacki wojteknowacki wojteknowacki approved these changes

@Droniu Droniu Droniu approved these changes

@andrzejewsky andrzejewsky Awaiting requested review from andrzejewsky

@krzysztofzuraw krzysztofzuraw Awaiting requested review from krzysztofzuraw

Assignees
No one assigned
Labels
run chromatic Run Chromatic visual tests on PR run e2e Runs cypress end-to-end tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add datagrid to the category listing page
5 participants
@poulch @wojteknowacki @andrzejewsky @krzysztofzuraw @Droniu