src/apps refactors batch
#3773
Merged
src/apps refactors batch
#3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove default exports in apps/views Rename apps/views components, ensure they have similar convention Refactor apps indexes files Rename marketplace mentions to appstore Rename useMarketplaceApps to useAppstoreApps Rename some marketplace mentions to appstore fix test
lkostrowski
force-pushed
the
refactors-app
branch
from
c80d636 to
d4efa5a
Compare
🦋 Changeset detectedLatest commit: d890bfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
krzysztofzuraw
approved these changes
Jun 27, 2023
poulch
approved these changes
Jun 27, 2023
poulch
pushed a commit
that referenced
this pull request
Jun 27, 2023
* Add refactors to apps folder Remove default exports in apps/views Rename apps/views components, ensure they have similar convention Refactor apps indexes files Rename marketplace mentions to appstore Rename useMarketplaceApps to useAppstoreApps Rename some marketplace mentions to appstore fix test * Add changeset
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #...
This PR introduces few refactors, briefly:
There will be more PRs like this, the goal to is to make this part of the codebase more maintainable
This PR is pure refactor, there should be no functional changes introduced
Screenshots
Pull Request Checklist
data-test-idare added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=1