Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unable to save attribute value #3814

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

poulch
Copy link
Member

@poulch poulch commented Jun 28, 2023

closes #3769

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants
  23. payments

CONTAINERS=7

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

🦋 Changeset detected

Latest commit: 583da23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to 3769-fix-unable-to-save-attribute-value June 28, 2023 13:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3769-fix-unable-to-save-attribute-value June 28, 2023 13:52 Inactive
@github-actions github-actions bot temporarily deployed to 3769-fix-unable-to-save-attribute-value June 28, 2023 20:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3769-fix-unable-to-save-attribute-value June 28, 2023 20:38 Inactive
@poulch poulch marked this pull request as ready for review June 28, 2023 20:45
@poulch poulch requested review from a team, krzysztofzuraw and Droniu June 28, 2023 20:45
@github-actions github-actions bot temporarily deployed to 3769-fix-unable-to-save-attribute-value June 28, 2023 20:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3769-fix-unable-to-save-attribute-value June 28, 2023 20:45 Inactive
@poulch poulch added the run e2e Runs cypress end-to-end tests label Jun 28, 2023
@poulch poulch force-pushed the 3769-fix-unable-to-save-attribute-value branch from 9058e0d to b4138ca Compare June 29, 2023 07:30
@github-actions github-actions bot temporarily deployed to 3769-fix-unable-to-save-attribute-value June 29, 2023 07:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3769-fix-unable-to-save-attribute-value June 29, 2023 07:31 Inactive
andrzejewsky
andrzejewsky previously approved these changes Jun 29, 2023
@poulch poulch merged commit a08d034 into main Jun 29, 2023
@poulch poulch deleted the 3769-fix-unable-to-save-attribute-value branch June 29, 2023 08:57
poulch added a commit that referenced this pull request Jun 29, 2023
@poulch poulch restored the 3769-fix-unable-to-save-attribute-value branch July 1, 2024 11:27
@poulch poulch deleted the 3769-fix-unable-to-save-attribute-value branch July 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run e2e Runs cypress end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to save attribute value
3 participants