-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View all orders of anonymous customer #3879
Conversation
|
Thanks for the PR! is it ready for review? I've noticed you have changed it to draft again? |
I have noticed that in the View Orders page screenshot there is also another customer (Holly Acosta). I need to check why it happened. |
By my side there seems to be a bug with the filter of orders by customer email. If I filter by customer email, for example maria.martinez@example.com (url: http://localhost:9000/orders?asc=false&sort=number&customer=maria.martinez%40example.com), here is what I get: Note that Holly Acosta and Alicia Perkins are registered customer. Can you check whether for you is working? |
@iammatthi we are aware of this. It's about the way of how the API sorts the results vs what we display as "customer" - sometimes there is no email while we display eg first name/last name |
All right. This PR's feature should then work as soon as the filter by email works. |
@iammatthi it seems that there are two issues with your PR that were caught by our CI:
|
fix: translation-messages
08ee545
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks a lot! CC: @timuric would you have a look?
@iammatthi looking great! Thank you! |
* feat: view all orders of anonymous customer * fix: formatting error fix: translation-messages
closes #3753
On the order page there is now a link under the email to see all orders of an anonymous customer.
Screenshots
Order page (before):
Order page (after):
View Orders page:
Pull Request Checklist
data-test-id
are added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=1