Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View all orders of anonymous customer #3879

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

iammatthi
Copy link
Contributor

@iammatthi iammatthi commented Jul 6, 2023

closes #3753

On the order page there is now a link under the email to see all orders of an anonymous customer.

Screenshots

Order page (before):
image

Order page (after):
image

View Orders page:
image

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants
  23. payments

CONTAINERS=1

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023

⚠️ No Changeset found

Latest commit: 08ee545

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023

CLA assistant check
All committers have signed the CLA.

@iammatthi iammatthi marked this pull request as ready for review July 6, 2023 16:42
@iammatthi iammatthi requested review from a team, andrzejewsky and krzysztofzuraw July 6, 2023 16:42
@iammatthi iammatthi changed the title feat: view all orders of anonymous customer View all orders of anonymous customer Jul 6, 2023
@iammatthi iammatthi marked this pull request as draft July 7, 2023 07:35
andrzejewsky
andrzejewsky previously approved these changes Jul 7, 2023
@andrzejewsky
Copy link
Member

Thanks for the PR! is it ready for review? I've noticed you have changed it to draft again?

@iammatthi
Copy link
Contributor Author

Thanks for the PR! is it ready for review? I've noticed you have changed it to draft again?

I have noticed that in the View Orders page screenshot there is also another customer (Holly Acosta). I need to check why it happened.

@iammatthi
Copy link
Contributor Author

By my side there seems to be a bug with the filter of orders by customer email. If I filter by customer email, for example maria.martinez@example.com (url: http://localhost:9000/orders?asc=false&sort=number&customer=maria.martinez%40example.com), here is what I get:
image

Note that Holly Acosta and Alicia Perkins are registered customer.

Can you check whether for you is working?

krzysztofzuraw
krzysztofzuraw previously approved these changes Jul 7, 2023
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review July 7, 2023 08:17
@andrzejewsky
Copy link
Member

@iammatthi we are aware of this. It's about the way of how the API sorts the results vs what we display as "customer" - sometimes there is no email while we display eg first name/last name

@iammatthi
Copy link
Contributor Author

All right. This PR's feature should then work as soon as the filter by email works.

@krzysztofzuraw
Copy link
Member

@iammatthi it seems that there are two issues with your PR that were caught by our CI:

  1. tsc-and-linters - it seems that there is a file not formatted by a prettier
  2. translation-messages - run npm run extract-messages and commit the result

fix: translation-messages
@iammatthi iammatthi dismissed stale reviews from krzysztofzuraw and andrzejewsky via 08ee545 July 10, 2023 12:32
Copy link
Member

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a lot! CC: @timuric would you have a look?

@timuric
Copy link
Contributor

timuric commented Jul 11, 2023

@iammatthi looking great! Thank you!

@andrzejewsky andrzejewsky merged commit 5b4d07d into saleor:main Jul 11, 2023
poulch pushed a commit that referenced this pull request Jul 13, 2023
* feat: view all orders of anonymous customer

* fix: formatting error
fix: translation-messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add "view all orders" to anonymous customers
5 participants