Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make titles font stronger #4001

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Make titles font stronger #4001

merged 3 commits into from
Jul 28, 2023

Conversation

timuric
Copy link
Contributor

@timuric timuric commented Jul 24, 2023

Screenshots

image

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@timuric timuric requested review from a team, krzysztofzuraw and Droniu July 24, 2023 15:49
@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: 4fd666b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@timuric timuric requested a review from andrzejewsky July 24, 2023 15:49
@timuric timuric self-assigned this Jul 24, 2023
@github-actions github-actions bot temporarily deployed to datagrid-theme-nudges July 24, 2023 15:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook datagrid-theme-nudges July 24, 2023 15:49 Inactive
poulch
poulch previously approved these changes Jul 25, 2023
@poulch
Copy link
Member

poulch commented Jul 25, 2023

@timuric please run npm run change:add to add change set 🙏🏻

@Droniu
Copy link
Member

Droniu commented Jul 25, 2023

@timuric I have added the changeset for you.

@github-actions github-actions bot temporarily deployed to datagrid-theme-nudges July 25, 2023 09:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook datagrid-theme-nudges July 25, 2023 09:09 Inactive
Droniu
Droniu previously approved these changes Jul 25, 2023
@andrzejewsky andrzejewsky merged commit 6cf3ab3 into main Jul 28, 2023
@andrzejewsky andrzejewsky deleted the datagrid-theme-nudges branch July 28, 2023 07:27
poulch pushed a commit that referenced this pull request Aug 4, 2023
* Make titles stronger

* Add changeset

* Nudge style property

---------

Co-authored-by: Michał Droń <droniu@droniu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants