Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests - removing redundant session cleanup, navigator confirmation added #4023

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

wojteknowacki
Copy link
Member

@wojteknowacki wojteknowacki commented Jul 26, 2023

Removed redundant session cleanup in before each test
Workflow before changes took: 28m 52s
Workflow after changes took: 23m 48s

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=6

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

⚠️ No Changeset found

Latest commit: f2fe104

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wojteknowacki wojteknowacki changed the title removing removing redundant session cleanup in before each test Jul 26, 2023
@github-actions github-actions bot temporarily deployed to test-fix-removed-redundant-session-cleanup July 26, 2023 14:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook test-fix-removed-redundant-session-cleanup July 26, 2023 14:52 Inactive
@github-actions github-actions bot temporarily deployed to test-fix-removed-redundant-session-cleanup July 27, 2023 07:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook test-fix-removed-redundant-session-cleanup July 27, 2023 07:43 Inactive
@wojteknowacki wojteknowacki changed the title removing redundant session cleanup in before each test tests - removing redundant session cleanup, navigator confirmation added Jul 27, 2023
@wojteknowacki wojteknowacki marked this pull request as ready for review July 27, 2023 08:30
poulch
poulch previously approved these changes Jul 27, 2023
yellowee
yellowee previously approved these changes Jul 27, 2023
Copy link
Contributor

@yellowee yellowee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@wojteknowacki wojteknowacki dismissed stale reviews from yellowee and poulch via f2fe104 July 28, 2023 06:18
@github-actions github-actions bot temporarily deployed to test-fix-removed-redundant-session-cleanup July 28, 2023 06:19 Inactive
@wojteknowacki wojteknowacki requested review from poulch and yellowee July 28, 2023 06:57
@wojteknowacki wojteknowacki merged commit 1bd4aea into main Jul 28, 2023
@wojteknowacki wojteknowacki deleted the test-fix-removed-redundant-session-cleanup branch July 28, 2023 07:48
poulch added a commit that referenced this pull request Aug 4, 2023
…ded (#4023)

* set notifiedAboutNavigator: true in local storage when logging in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants