removed percy and demo tests code - not useful anymore #4029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
temporarily deployed
to
storybook remove-unused-workflows
NyanKiyoshi
previously approved these changes
Jul 27, 2023
NyanKiyoshi
changed the title
| @@ -316,8 +316,6 @@ | |||
| "cy:run:critical:parallel": "cypress run --record --env grepTags=@critical --parallel --tag Critical", | |||
| "cy:run:allEnv:parallel": "cypress run --record --env grepTags=@allEnv --parallel", | |||
| "cy:run:stable:parallel": "cypress run --record --env grepTags=@critical --parallel --tag Stable", | |||
| "cy:percy": "CYPRESS_demoTests=true percy exec -- npm run cy:run", | |||
There was a problem hiding this comment.
Suggestion: Remove precy from devDependencies
Remove @percy/cli / @percy/cypress
github-actions
bot
temporarily deployed
to
storybook remove-unused-workflows
Droniu
approved these changes
Jul 28, 2023
krzysztofzuraw
approved these changes
Jul 28, 2023
NyanKiyoshi
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Percy was replaced with chromatic so can be removed. Demo tests are being done manually so configuration is not needed.
Closes #3852
### Screenshots
Pull Request Checklist
data-test-idare added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=2