Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce datagrid on attributes list view #4040

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Conversation

poulch
Copy link
Member

@poulch poulch commented Aug 1, 2023

closes #3979

Screenshots

Before After
Screenshot 2023-08-01 at 11 14 13 Screenshot 2023-08-01 at 11 13 49

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023

🦋 Changeset detected

Latest commit: 66b8b5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to 3878-datagrid-on-attributes August 1, 2023 08:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3878-datagrid-on-attributes August 1, 2023 08:45 Inactive
@github-actions github-actions bot temporarily deployed to 3878-datagrid-on-attributes August 1, 2023 09:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3878-datagrid-on-attributes August 1, 2023 09:07 Inactive
@poulch poulch marked this pull request as ready for review August 1, 2023 09:15
@poulch poulch requested review from a team, andrzejewsky and krzysztofzuraw August 1, 2023 09:15
krzysztofzuraw
krzysztofzuraw previously approved these changes Aug 1, 2023
@poulch poulch requested a review from Droniu August 1, 2023 09:58
@github-actions github-actions bot temporarily deployed to 3878-datagrid-on-attributes August 1, 2023 14:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3878-datagrid-on-attributes August 1, 2023 14:03 Inactive
@poulch poulch requested a review from krzysztofzuraw August 1, 2023 14:06
andrzejewsky
andrzejewsky previously approved these changes Aug 1, 2023
krzysztofzuraw
krzysztofzuraw previously approved these changes Aug 1, 2023
Droniu
Droniu previously approved these changes Aug 2, 2023
@poulch poulch dismissed stale reviews from krzysztofzuraw and andrzejewsky via 66b8b5e August 3, 2023 07:19
@github-actions github-actions bot temporarily deployed to 3878-datagrid-on-attributes August 3, 2023 07:19 Inactive
@andrzejewsky andrzejewsky self-requested a review August 3, 2023 08:08
@poulch poulch merged commit 9037c9c into main Aug 3, 2023
@poulch poulch deleted the 3878-datagrid-on-attributes branch August 3, 2023 08:23
@poulch poulch restored the 3878-datagrid-on-attributes branch July 1, 2024 11:27
@poulch poulch deleted the 3878-datagrid-on-attributes branch July 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply datagrid to attributes page
5 participants